Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert #21356(able to sort bar on the bar chart V2) #21481

Merged
merged 1 commit into from
Sep 16, 2022

Conversation

stephenLYZ
Copy link
Member

Reverts #21356

@codecov
Copy link

codecov bot commented Sep 15, 2022

Codecov Report

Merging #21481 (b490123) into master (4fcc1d9) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master   #21481      +/-   ##
==========================================
- Coverage   66.67%   66.66%   -0.01%     
==========================================
  Files        1791     1791              
  Lines       68459    68458       -1     
  Branches     7268     7270       +2     
==========================================
- Hits        45643    45638       -5     
- Misses      20955    20959       +4     
  Partials     1861     1861              
Flag Coverage Δ
hive 53.04% <ø> (ø)
javascript 52.84% <100.00%> (-0.01%) ⬇️
mysql 78.18% <ø> (ø)
postgres 78.24% <ø> (-0.02%) ⬇️
presto 52.94% <ø> (ø)
python 81.38% <ø> (-0.02%) ⬇️
sqlite 76.74% <ø> (ø)
unit 51.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../plugin-chart-echarts/src/Timeseries/buildQuery.ts 66.66% <ø> (ø)
...et-ui-chart-controls/src/operators/sortOperator.ts 100.00% <100.00%> (ø)
superset/reports/commands/log_prune.py 85.71% <0.00%> (-3.58%) ⬇️
superset/commands/importers/v1/utils.py 92.20% <0.00%> (-1.30%) ⬇️
superset/common/query_object.py 93.87% <0.00%> (-0.52%) ⬇️
superset/reports/commands/execute.py 91.19% <0.00%> (-0.36%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@zhaoyongjie zhaoyongjie changed the title Revert "feat(plugin-chart-echarts): able to sort bar on the bar chart V2" Revert: feat(plugin-chart-echarts): able to sort bar on the bar chart V2 Sep 16, 2022
@zhaoyongjie zhaoyongjie changed the title Revert: feat(plugin-chart-echarts): able to sort bar on the bar chart V2 fix: Revert - feat(plugin-chart-echarts): able to sort bar on the bar chart V2 Sep 16, 2022
@zhaoyongjie zhaoyongjie changed the title fix: Revert - feat(plugin-chart-echarts): able to sort bar on the bar chart V2 fix: revert #21356(able to sort bar on the bar chart V2) Sep 16, 2022
@zhaoyongjie zhaoyongjie merged commit 1c0bff3 into master Sep 16, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 labels Mar 13, 2024
@mistercrunch mistercrunch deleted the revert-21356-feat-sort-operator branch March 26, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants