Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(plugin-chart-echarts): able to sort bar on the bar chart V2 #21356

Merged
merged 1 commit into from
Sep 13, 2022

Conversation

stephenLYZ
Copy link
Member

@stephenLYZ stephenLYZ commented Sep 7, 2022

SUMMARY

This PR supports sorting bar on the bar chart V2. The key point is using the label in metrcs or columns to sort. If orderBy can't find these lists, just don't use the sort operator, it's a limitation.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

after

2022-09-07.8.46.59.mov

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Sep 7, 2022

Codecov Report

Merging #21356 (8fe07e9) into master (1cc2148) will increase coverage by 0.10%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master   #21356      +/-   ##
==========================================
+ Coverage   66.47%   66.57%   +0.10%     
==========================================
  Files        1789     1791       +2     
  Lines       68381    68444      +63     
  Branches     7276     7297      +21     
==========================================
+ Hits        45455    45568     +113     
+ Misses      21051    20996      -55     
- Partials     1875     1880       +5     
Flag Coverage Δ
javascript 52.73% <100.00%> (+0.22%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../plugin-chart-echarts/src/Timeseries/buildQuery.ts 66.66% <ø> (ø)
...et-ui-chart-controls/src/operators/sortOperator.ts 100.00% <100.00%> (ø)
...cy-preset-chart-nvd3/src/TimePivot/controlPanel.ts 33.33% <0.00%> (-16.67%) ⬇️
...t-controls/src/sections/echartsTimeSeriesQuery.tsx 33.33% <0.00%> (-16.67%) ⬇️
...perset-ui-chart-controls/src/sections/sections.tsx 87.50% <0.00%> (-12.50%) ⬇️
...et-ui-chart-controls/src/shared-controls/index.tsx 48.43% <0.00%> (-2.83%) ⬇️
...trols/DateFilterControl/components/CustomFrame.tsx 70.96% <0.00%> (-1.45%) ⬇️
...d/src/explore/components/PropertiesModal/index.tsx 62.90% <0.00%> (-1.04%) ⬇️
...rontend/src/views/CRUD/dashboard/DashboardList.tsx 56.60% <0.00%> (-0.54%) ⬇️
...src/dashboard/components/PropertiesModal/index.tsx 61.81% <0.00%> (-0.38%) ⬇️
... and 28 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rusackas
Copy link
Member

rusackas commented Sep 7, 2022

/testenv up

@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2022

@rusackas Ephemeral environment spinning up at http://52.25.229.84:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

Copy link
Member

@zhaoyongjie zhaoyongjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhaoyongjie zhaoyongjie merged commit 59437ea into apache:master Sep 13, 2022
@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

stephenLYZ added a commit that referenced this pull request Sep 15, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants