Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial selection for sunburst graph #215

Closed
gbrian opened this issue Mar 31, 2016 · 3 comments
Closed

Initial selection for sunburst graph #215

gbrian opened this issue Mar 31, 2016 · 3 comments

Comments

@gbrian
Copy link
Contributor

gbrian commented Mar 31, 2016

Hi there,

I've added a few lines to sunburst to change the way it's initially painted, now it shows the first path.

image

Makes sense to add a new setting kind of "always show main path" ?
Thanks

PS: Just did this:

// Initial selection
      var mainpath = function(){
        var c = tree.children[0];
        while(c.hasOwnProperty('children') && c.children.length != 0)
            c = c.children[0];
        return c;
      }
      highlighpath(mainpath());
@williaster
Copy link
Contributor

Nice. I don't have a strong opinion on this, I'd say go for it if you think it'd be useful. @mistercrunch?

Since it's so easy to update on mouseover I also don't have a strong opinion on if there needs to be a toggle at all, it could just always do this? If you want to add a toggle you'll have to get into python land, see any vis in viz.py and you can see how the form controls are added. Then add the check for toggle state on the JS side. Encapsulating all of the highlighting into a highlightPath() function is cool.

@mistercrunch
Copy link
Member

Sorry about the delay. I think people might go either way on this one, though having an actual option to preselect a specific one may be marginally useful, arbitrarily selecting the first one doesn't seem that useful to me.

@gbrian
Copy link
Contributor Author

gbrian commented Apr 11, 2016

Idea behind this was to show the main path, the one with highest percentage.
At the same time the graph is shown with more data from the first refresh, as I plan to have it self refreshed is useful to have it showing that path.
I'm planning to keep last user selections as well...and maybe allow double selection to have a two paths comparison...but maybe that's only usegul for me ;)

graceguo-supercat pushed a commit to graceguo-supercat/superset that referenced this issue Oct 4, 2021
…pache#215)

* feat: add Wrapper support and bounding box for dynamic width/height

* fix: unit tests

* fix: address comments and update unit tests

* docs: update storybook
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this issue Nov 17, 2021
…pache#215)

* feat: add Wrapper support and bounding box for dynamic width/height

* fix: unit tests

* fix: address comments and update unit tests

* docs: update storybook
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this issue Nov 17, 2021
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this issue Nov 24, 2021
…pache#215)

* feat: add Wrapper support and bounding box for dynamic width/height

* fix: unit tests

* fix: address comments and update unit tests

* docs: update storybook
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this issue Nov 24, 2021
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this issue Nov 25, 2021
…pache#215)

* feat: add Wrapper support and bounding box for dynamic width/height

* fix: unit tests

* fix: address comments and update unit tests

* docs: update storybook
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this issue Nov 25, 2021
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this issue Nov 26, 2021
…pache#215)

* feat: add Wrapper support and bounding box for dynamic width/height

* fix: unit tests

* fix: address comments and update unit tests

* docs: update storybook
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this issue Nov 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants