Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Reset dataset name after saving a new dataset in SQL Lab #21529

Merged
merged 1 commit into from
Sep 21, 2022
Merged

fix: Reset dataset name after saving a new dataset in SQL Lab #21529

merged 1 commit into from
Sep 21, 2022

Conversation

EugeneTorap
Copy link
Contributor

SUMMARY

Fix #21271 issue when we create a dataset and provide some name and then want to do it again with the same name. In second dataset creation we got Untitled Query 7 08/31/2022 17:58:02 name but input has qwe1 name

BEFORE SCREENSHOTS OR ANIMATED GIF

187712014-c11971cb-1634-4287-a540-163eba57b83a.mov

AFTER SCREENSHOTS OR ANIMATED GIF

Screen.Recording.2022-09-20.at.14.48.32.mov

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Sep 20, 2022

Codecov Report

Merging #21529 (c90287c) into master (94a724e) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master   #21529      +/-   ##
==========================================
- Coverage   66.67%   66.66%   -0.01%     
==========================================
  Files        1793     1793              
  Lines       68493    68500       +7     
  Branches     7275     7279       +4     
==========================================
  Hits        45665    45665              
- Misses      20966    20971       +5     
- Partials     1862     1864       +2     
Flag Coverage Δ
javascript 52.82% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...d/src/SqlLab/components/SaveDatasetModal/index.tsx 52.87% <100.00%> (ø)
...frontend/src/components/ListView/Filters/index.tsx 52.17% <0.00%> (-14.50%) ⬇️
...src/dashboard/components/PropertiesModal/index.tsx 61.07% <0.00%> (-0.75%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@kgabryje kgabryje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! @yousoph Can you confirm that that's the expected flow?

@yousoph
Copy link
Member

yousoph commented Sep 21, 2022

/testenv up

@github-actions
Copy link
Contributor

@yousoph Ephemeral environment spinning up at http://35.90.85.142:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@yousoph
Copy link
Member

yousoph commented Sep 21, 2022

Looks good to me! Thanks for the fix, @EugeneTorap !!

@kgabryje kgabryje merged commit cbadb87 into apache:master Sep 21, 2022
@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

@EugeneTorap EugeneTorap deleted the fix/reset-dataset-name branch September 22, 2022 02:08
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dataset creating issues in SQL Lab
4 participants