fix(dashboard): show correct roles for dashboard access dropdown

[mayurnewase]

SUMMARY

Fixes: #21538
regression from #20837

TESTING INSTRUCTIONS

Enable DASHBOARD_RBAC feature flag
Add 1 role
Add 1 active and 1 inactive user
Create 1 dashboard
Click on edit dashboard from actions
Check owners dropdown shows only active users
Check roles dropdown shows all roles available

ADDITIONAL INFORMATION

• Has associated issue: Unable to see roles in drop down in edit dashboard #21538
• Required feature flags: DASHBOARD_RBAC
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[codecov]

Codecov Report

Merging #21549 (8fa7301) into master (fb835d1) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master   #21549      +/-   ##
==========================================
- Coverage   66.68%   66.65%   -0.03%     
==========================================
  Files        1793     1793              
  Lines       68538    68627      +89     
  Branches     7282     7309      +27     
==========================================
+ Hits        45702    45745      +43     
- Misses      20974    21015      +41     
- Partials     1862     1867       +5     

Flag	Coverage Δ
javascript	52.85% <100.00%> (-0.02%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...src/dashboard/components/PropertiesModal/index.tsx	67.06% <100.00%> (+5.98%)	⬆️
...iews/CRUD/data/dataset/AddDataset/Footer/index.tsx	33.33% <0.00%> (-66.67%)	⬇️
.../plugin-chart-pivot-table/src/plugin/buildQuery.ts	42.85% <0.00%> (-12.70%)	⬇️
...nd/plugins/plugin-chart-table/src/controlPanel.tsx	53.12% <0.00%> (-9.84%)	⬇️
...ntend/plugins/plugin-chart-table/src/buildQuery.ts	56.25% <0.00%> (-4.77%)	⬇️
...ugin-chart-pivot-table/src/plugin/controlPanel.tsx	4.16% <0.00%> (-2.98%)	⬇️
...et-ui-chart-controls/src/shared-controls/index.tsx	57.14% <0.00%> (-2.48%)	⬇️
...frontend/src/components/DatabaseSelector/index.tsx	93.93% <0.00%> (-1.30%)	⬇️
...set-frontend/src/views/CRUD/data/dataset/styles.ts	100.00% <0.00%> (ø)
...et-frontend/src/components/TableSelector/index.tsx	80.00% <0.00%> (ø)
... and 7 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[michael-s-molina]

@mayurnewase @zephyring #20837 also modified the owners in src/components/Datasource/DatasourceEditor. Shouldn't the same fix be applied there?

[mayurnewase]

@michael-s-molina datasource editor only has owner selection, so it correctly filters out inactive users.
here loadAccessOptionsis shared between users and roles which had to be updated.
I don't think we need any change there.

[michael-s-molina]

LGTM

[mayurnewase]

thanks.