Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: only show active user for chart/dashboard/datasource owner drop… #20837

Merged
merged 11 commits into from
Sep 6, 2022

Conversation

zephyring
Copy link
Contributor

@zephyring zephyring commented Jul 22, 2022

…down

SUMMARY

  1. Don't show inactive user in the owner dropdown list for dashboard/chart/dataset by leveraging the extra fields returned from API

AFTER SCREENSHOTS OR ANIMATED GIF

Screen Shot 2022-09-01 at 10 24 09 AM

Screen Shot 2022-09-01 at 10 25 58 AM

Screen Shot 2022-09-01 at 10 27 22 AM

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jul 22, 2022

Codecov Report

Merging #20837 (e76ec84) into master (c3a00d4) will increase coverage by 0.01%.
The diff coverage is 66.37%.

❗ Current head e76ec84 differs from pull request most recent head d6d0dc3. Consider uploading reports for the commit d6d0dc3 to get more accurate results

@@            Coverage Diff             @@
##           master   #20837      +/-   ##
==========================================
+ Coverage   66.44%   66.45%   +0.01%     
==========================================
  Files        1786     1789       +3     
  Lines       68267    68300      +33     
  Branches     7263     7275      +12     
==========================================
+ Hits        45357    45388      +31     
+ Misses      21041    21037       -4     
- Partials     1869     1875       +6     
Flag Coverage Δ
javascript 52.49% <71.73%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/SqlLab/App.jsx 0.00% <0.00%> (ø)
...d/src/SqlLab/components/TabbedSqlEditors/index.jsx 54.23% <0.00%> (-0.94%) ⬇️
...ntend/src/SqlLab/components/TableElement/index.tsx 72.30% <ø> (ø)
...end/src/components/Datasource/DatasourceEditor.jsx 65.35% <0.00%> (-0.26%) ⬇️
...src/dashboard/components/PropertiesModal/index.tsx 61.81% <0.00%> (-0.38%) ⬇️
...d/src/explore/components/PropertiesModal/index.tsx 62.90% <0.00%> (-1.04%) ⬇️
superset-frontend/src/utils/localStorageHelpers.ts 90.00% <ø> (ø)
superset-frontend/src/views/App.tsx 0.00% <0.00%> (ø)
...perset/utils/pandas_postprocessing/contribution.py 100.00% <ø> (ø)
superset/utils/network.py 34.37% <7.69%> (-3.56%) ⬇️
... and 23 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@zephyring zephyring force-pushed the zef/filter_inactive_user_from_owner branch from 1a3aac3 to ef600ef Compare July 25, 2022 21:07
@zephyring zephyring force-pushed the zef/filter_inactive_user_from_owner branch from 19dfad8 to 077c36b Compare August 17, 2022 22:18
@pull-request-size pull-request-size bot added size/L and removed size/M labels Aug 18, 2022
@pull-request-size pull-request-size bot added size/M and removed size/L labels Sep 1, 2022
@zephyring zephyring force-pushed the zef/filter_inactive_user_from_owner branch from 1b80ac6 to 343adfe Compare September 1, 2022 17:30
@dpgaspar dpgaspar merged commit 9be4870 into apache:master Sep 6, 2022
@dpgaspar dpgaspar deleted the zef/filter_inactive_user_from_owner branch September 6, 2022 18:17
@mayurnewase
Copy link
Contributor

mayurnewase commented Sep 22, 2022

this causes 1 regression.
the same function is used for listing roles in dashboard roles list, which doesn't have active field, so the dropdown doesn't show any role for DASHBOARD_RBAC.

@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants