Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: deprecate created_slices API endpoint #21664

Conversation

dpgaspar
Copy link
Member

SUMMARY

One more step to push the deprecation on /superset/* endpoints. Deprecates /superset/created_slices/.
Creates a new simple filter exactly has already done for dashboards and adapts the UI for profiles to use API v1 with the new filter

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Sep 30, 2022

Codecov Report

Merging #21664 (504987e) into master (389fa31) will increase coverage by 0.00%.
The diff coverage is 92.30%.

@@           Coverage Diff           @@
##           master   #21664   +/-   ##
=======================================
  Coverage   66.82%   66.83%           
=======================================
  Files        1798     1799    +1     
  Lines       68824    68841   +17     
  Branches     7331     7332    +1     
=======================================
+ Hits        45994    46011   +17     
+ Misses      20952    20950    -2     
- Partials     1878     1880    +2     
Flag Coverage Δ
hive 52.89% <75.00%> (-0.02%) ⬇️
javascript 53.15% <80.00%> (-0.01%) ⬇️
mysql 78.22% <100.00%> (-0.01%) ⬇️
postgres 78.29% <100.00%> (-0.01%) ⬇️
presto 52.80% <75.00%> (-0.02%) ⬇️
python 81.43% <100.00%> (+0.01%) ⬆️
sqlite 76.79% <100.00%> (-0.01%) ⬇️
unit 50.93% <75.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/types/bootstrapTypes.ts 100.00% <ø> (ø)
superset/charts/api.py 86.03% <ø> (ø)
...frontend/src/profile/components/CreatedContent.tsx 81.81% <80.00%> (+4.04%) ⬆️
superset/charts/filters.py 87.03% <100.00%> (+1.62%) ⬆️
superset/dashboards/filters.py 93.25% <100.00%> (+4.49%) ⬆️
superset/views/core.py 76.06% <100.00%> (+0.01%) ⬆️
...et-ui-chart-controls/src/shared-controls/index.tsx 54.23% <0.00%> (-2.91%) ⬇️
...d/src/SqlLab/components/SqlEditorLeftBar/index.tsx 52.23% <0.00%> (-2.05%) ⬇️
...d/src/SqlLab/components/ShareSqlLabQuery/index.tsx 80.76% <0.00%> (-1.99%) ⬇️
...t-frontend/src/explore/actions/saveModalActions.js 97.26% <0.00%> (-1.34%) ⬇️
... and 15 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with 1 nit

@dpgaspar dpgaspar merged commit 3057e42 into apache:master Oct 4, 2022
@dpgaspar dpgaspar deleted the danielgaspar/sc-42038/migrate-superset-created-slices-to-api-v1 branch October 4, 2022 08:13
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants