-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: deprecate created_slices API endpoint #21664
feat: deprecate created_slices API endpoint #21664
Conversation
Codecov Report
@@ Coverage Diff @@
## master #21664 +/- ##
=======================================
Coverage 66.82% 66.83%
=======================================
Files 1798 1799 +1
Lines 68824 68841 +17
Branches 7331 7332 +1
=======================================
+ Hits 45994 46011 +17
+ Misses 20952 20950 -2
- Partials 1878 1880 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with 1 nit
Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
…perset-created-slices-to-api-v1' into danielgaspar/sc-42038/migrate-superset-created-slices-to-api-v1
SUMMARY
One more step to push the deprecation on
/superset/*
endpoints. Deprecates/superset/created_slices/
.Creates a new simple filter exactly has already done for dashboards and adapts the UI for profiles to use API v1 with the new filter
ADDITIONAL INFORMATION