Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adds the HORIZONTAL_FILTER_BAR feature flag #21935

Merged

Conversation

michael-s-molina
Copy link
Member

SUMMARY

Adds the HORIZONTAL_FILTER_BAR feature flag under the Development category.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Oct 25, 2022

Codecov Report

Merging #21935 (2a542b7) into master (fa67315) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #21935   +/-   ##
=======================================
  Coverage   66.95%   66.95%           
=======================================
  Files        1807     1807           
  Lines       69182    69182           
  Branches     7402     7402           
=======================================
  Hits        46319    46319           
  Misses      20952    20952           
  Partials     1911     1911           
Flag Coverage Δ
hive 52.92% <ø> (ø)
javascript 53.38% <ø> (ø)
mysql 78.37% <ø> (ø)
postgres 78.43% <ø> (ø)
presto 52.82% <ø> (ø)
python 81.49% <ø> (ø)
sqlite 76.92% <ø> (ø)
unit 51.06% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ackages/superset-ui-core/src/utils/featureFlags.ts 100.00% <ø> (ø)
superset/config.py 91.69% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@kgabryje kgabryje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@michael-s-molina michael-s-molina merged commit 779d9f7 into apache:master Oct 26, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants