Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add form data for empty state control to save dataset #21944

Merged
merged 2 commits into from
Oct 28, 2022

Conversation

pkdotson
Copy link
Member

@pkdotson pkdotson commented Oct 26, 2022

SUMMARY

There is an issue where if a user tries to save the dataset from the time control, when user power charts from query, user will be shown an error of missing params. This was because of the potential for the database info to be structured different from the original object structure.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

before

Screen.Recording.2022-10-27.at.12.27.34.PM.mov

TESTING INSTRUCTIONS

Run a sql query in sql lab that has no temporal columns
Create a chart with the query powering the chart
In the Time section, click the blank state button to create a dataset

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@pkdotson pkdotson merged commit d3f930a into apache:master Oct 28, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants