fix: error_parsing #21946
Merged
fix: error_parsing #21946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #21946 +/- ##
==========================================
+ Coverage 65.71% 67.17% +1.46%
==========================================
Files 1807 1807
Lines 69202 69729 +527
Branches 7402 7402
==========================================
+ Hits 45474 46841 +1367
+ Misses 21817 20977 -840
Partials 1911 1911
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
superset/reports/commands/execute.py
Outdated
| @@ -16,6 +16,7 @@ | |||
| # under the License. | |||
| import json | |||
| import logging | |||
| import re | |||
There was a problem hiding this comment.
Are we using it somehow in this file?
There was a problem hiding this comment.
no this was leftover! Thank you!
AAfghahi
force-pushed
the
arashPhillip/fixError
branch
from
c1ed969
to
fecf283
Compare
AAfghahi
force-pushed
the
arashPhillip/fixError
branch
from
fecf283
to
a976e6d
Compare
AAfghahi
force-pushed
the
arashPhillip/fixError
branch
from
a976e6d
to
998e1e0
Compare
eschutho
approved these changes
Oct 28, 2022
jinghua-qa
pushed a commit
to preset-io/superset
that referenced
this pull request
Oct 31, 2022
(cherry picked from commit 33fc578)
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
There was SQL information in the logs that we were sending, this fixes the error message to make sure that it does not happen.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION