Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: error_parsing #21946

Merged
merged 2 commits into from
Oct 28, 2022
Merged

fix: error_parsing #21946

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d29ee8c
error_parsing
AAfghahi Oct 26, 2022
998e1e0
removed error text from header_data
AAfghahi Oct 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions superset/reports/commands/execute.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -322,7 +322,6 @@ def _get_log_data(self) -> HeaderDataType:
"chart_id": chart_id,
"dashboard_id": dashboard_id,
"owners": self._report_schedule.owners,
"error_text": None,
}
return log_data

Expand Down Expand Up @@ -354,7 +353,6 @@ def _get_notification_content(self) -> NotificationContent:
if not csv_data:
error_text = "Unexpected missing csv file"
if error_text:
header_data["error_text"] = error_text
return NotificationContent(
name=self._report_schedule.name,
text=error_text,
Expand Down Expand Up @@ -434,7 +432,6 @@ def send_error(self, name: str, message: str) -> None:
:raises: NotificationError
"""
header_data = self._get_log_data()
header_data["error_text"] = message
logger.info(
"header_data in notifications for alerts and reports %s, taskid, %s",
header_data,
Expand Down
1 change: 0 additions & 1 deletion superset/utils/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,6 @@ class HeaderDataType(TypedDict):
notification_source: Optional[str]
chart_id: Optional[int]
dashboard_id: Optional[int]
error_text: Optional[str]


class DatasourceDict(TypedDict):
Expand Down
2 changes: 1 addition & 1 deletion tests/integration_tests/reports/commands/execute_dashboard_report_tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,4 +110,4 @@ def test_report_with_header_data(
assert header_data.get("notification_format") == report_schedule.report_format
assert header_data.get("notification_source") == ReportSourceFormat.DASHBOARD
assert header_data.get("notification_type") == report_schedule.type
assert len(send_email_smtp_mock.call_args.kwargs["header_data"]) == 7
assert len(send_email_smtp_mock.call_args.kwargs["header_data"]) == 6
1 change: 0 additions & 1 deletion tests/unit_tests/notifications/email_tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@ def test_render_description_with_html() -> None:
"notification_source": None,
"chart_id": None,
"dashboard_id": None,
"error_text": None,
},
)
email_body = (
Expand Down