Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Revert shared controls typing change. #22014

Merged
merged 1 commit into from
Nov 3, 2022

Conversation

codyml
Copy link
Member

@codyml codyml commented Nov 3, 2022

SUMMARY

As part of unifying drag-and-drop and non-drag-and-drop controls in #21315, I unnecessarily changed a type to optional. This PR reverts that change and instead updates the viz plugin that was causing TypeScript to complain to match the previous function signature.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TESTING INSTRUCTIONS

  • Confirm that Histogram charts don't look any different than they did before.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Nov 3, 2022

Codecov Report

Merging #22014 (5625865) into master (72598a5) will increase coverage by 0.03%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master   #22014      +/-   ##
==========================================
+ Coverage   65.72%   65.76%   +0.03%     
==========================================
  Files        1809     1812       +3     
  Lines       69335    69402      +67     
  Branches     7413     7448      +35     
==========================================
+ Hits        45571    45640      +69     
+ Misses      21853    21842      -11     
- Partials     1911     1920       +9     
Flag Coverage Δ
javascript 53.50% <0.00%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...d/packages/superset-ui-chart-controls/src/types.ts 100.00% <ø> (ø)
.../legacy-plugin-chart-histogram/src/controlPanel.ts 40.00% <0.00%> (ø)
...t-ui-chart-controls/src/shared-controls/mixins.tsx 16.66% <0.00%> (-16.67%) ⬇️
...perset-ui-chart-controls/src/sections/sections.tsx 71.42% <0.00%> (-16.08%) ⬇️
...l/AdhocFilterEditPopoverSimpleTabContent/index.tsx 62.73% <0.00%> (-6.29%) ⬇️
...ontrols/DndColumnSelectControl/DndFilterSelect.tsx 42.60% <0.00%> (-1.43%) ⬇️
superset-frontend/src/explore/constants.ts 100.00% <0.00%> (ø)
superset-frontend/src/components/Modal/Modal.tsx 89.18% <0.00%> (ø)
...perset-frontend/src/addSlice/AddSliceContainer.tsx 59.61% <0.00%> (ø)
...set-frontend/src/explore/actions/hydrateExplore.ts 57.14% <0.00%> (ø)
... and 21 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@zhaoyongjie zhaoyongjie merged commit 4cbd70d into apache:master Nov 3, 2022
@codyml
Copy link
Member Author

codyml commented Nov 3, 2022

Thanks @stephenLYZ and @zhaoyongjie!

@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants