Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adding missing examples for bubble chart, bullet chart, calendar heatmap chart and country map chart in the gallery #22523

Merged
merged 4 commits into from
Dec 31, 2022

Conversation

yash-samsung
Copy link
Contributor

SUMMARY

Adding examples for bubble chart, bullet chart, calendar heatmap chart and country map chart which were missing in the gallery.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:
bubble_chart_before

(Please note that text in red 'No Example' just to show/visualize that there are no examples. In actual, it remains empty)

After:
bubble_chart_after

Before there was no example at the time of selecting the chart type from gallery, where in after image example can be seen in the lower right 'Examples' section. Examples will also be reflected the same way for bullet chart, calendar heatmap chart and country map chart.

TESTING INSTRUCTIONS

At the time of selecting a chart type from the gallery, example will be visible for bubble chart, bullet chart, calendar heatmap chart and country map chart as seen in the after screenshot above.

ADDITIONAL INFORMATION

  • Has associated issue: Fixes a part of [Gallery] Some chart type in gallery do not have example #16707
  • Required feature flags:
  • Changes UI: Only example images will be loaded on the UI. It won't change anything the way user interacts with UI.
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️
We hope to see you in our Slack community too!

@codecov
Copy link

codecov bot commented Dec 24, 2022

Codecov Report

Merging #22523 (3eaea0d) into master (9b26794) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #22523   +/-   ##
=======================================
  Coverage   66.90%   66.90%           
=======================================
  Files        1851     1851           
  Lines       70696    70696           
  Branches     7764     7764           
=======================================
  Hits        47299    47299           
  Misses      21375    21375           
  Partials     2022     2022           
Flag Coverage Δ
javascript 53.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../plugins/legacy-plugin-chart-calendar/src/index.js 66.66% <ø> (ø)
...ugins/legacy-plugin-chart-country-map/src/index.js 66.66% <ø> (ø)
...ugins/legacy-preset-chart-nvd3/src/Bubble/index.js 66.66% <ø> (ø)
...ugins/legacy-preset-chart-nvd3/src/Bullet/index.js 66.66% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding these missing examples! LGTM

@villebro villebro merged commit 839ec7c into apache:master Dec 31, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants