Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(explore): datasource_type typo #22543

Merged
merged 1 commit into from
Dec 31, 2022
Merged

fix(explore): datasource_type typo #22543

merged 1 commit into from
Dec 31, 2022

Conversation

Musa10
Copy link
Contributor

@Musa10 Musa10 commented Dec 29, 2022

fix(explore): datasource_type typo

SUMMARY

Fixing datasource_type variable name in exploreUtils to recognise the dataset type when adding a new chart (for example)...(missing datasource error occured before the fix)

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️
We hope to see you in our Slack community too!

Copy link
Contributor Author

@Musa10 Musa10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a typo error that caused undefined datasource_type when adding a new chart

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @Musa10 ! Code change LGTM, but please add a description to the PR, preferably including reproduction steps for understanding why this change is needed.

@villebro villebro changed the title Fixing datasource_type typo fix(explore): datasource_type typo Dec 30, 2022
@codecov
Copy link

codecov bot commented Dec 30, 2022

Codecov Report

Merging #22543 (9a7a6f5) into master (b6d39d1) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master   #22543   +/-   ##
=======================================
  Coverage   66.91%   66.91%           
=======================================
  Files        1851     1851           
  Lines       70715    70715           
  Branches     7766     7766           
=======================================
  Hits        47320    47320           
  Misses      21373    21373           
  Partials     2022     2022           
Flag Coverage Δ
javascript 53.85% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../explore/exploreUtils/getParsedExploreURLParams.ts 83.33% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Musa10
Copy link
Contributor Author

Musa10 commented Dec 31, 2022

@villebro Thanks for your review... description added

@villebro villebro merged commit c2ace8d into apache:master Dec 31, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants