-
Notifications
You must be signed in to change notification settings - Fork 13.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(explore): datasource_type typo #22543
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️
We hope to see you in our Slack community too!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a typo error that caused undefined datasource_type when adding a new chart
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix @Musa10 ! Code change LGTM, but please add a description to the PR, preferably including reproduction steps for understanding why this change is needed.
Codecov Report
@@ Coverage Diff @@
## master #22543 +/- ##
=======================================
Coverage 66.91% 66.91%
=======================================
Files 1851 1851
Lines 70715 70715
Branches 7766 7766
=======================================
Hits 47320 47320
Misses 21373 21373
Partials 2022 2022
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@villebro Thanks for your review... description added |
fix(explore): datasource_type typo
SUMMARY
Fixing datasource_type variable name in exploreUtils to recognise the dataset type when adding a new chart (for example)...(missing datasource error occured before the fix)
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION