Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cross-filtering resets the table column sorting #22691

Closed
2 tasks done
saghatelian opened this issue Jan 11, 2023 · 1 comment · Fixed by #23318
Closed
2 tasks done

Cross-filtering resets the table column sorting #22691

saghatelian opened this issue Jan 11, 2023 · 1 comment · Fixed by #23318
Assignees
Labels
#bug Bug report

Comments

@saghatelian
Copy link
Contributor

Cross-filtering resets the table column sorting.

How to reproduce the bug

  1. Create 2 table charts, prefferably with 300+ rows, that have at least one column in common (in my example I use the table birth_names from the Superset example DB for both table charts)
  2. Enable "DASHBOARD CROSS FILTERS" for both table charts
  3. Put both table charts on a dashboard (let's call them "Table 1" and "Table 2")
  4. Click on a column title on "Table 2" to sort by that column.
  5. Click on a table cell on "Table 2" to "cross-filter" the data of the "Table 1"

Expected results

The "Table 1" data should be filtered, while the "Table 2" should remain unchanged, i.e. sorted by the selected column regardless of the table cell clicked

Actual results

The sorting is automatically lost (reset) every time I click on any cell.
Weirdly, although both table charts use the same data source, the bug affects only one of the tables. As you can see from the screen recordings, the sorting is lost when I click on a cell in "Table 2", but isn't lost when I click on a cell in "Table 1".

Screenshots

Screen.recording.2023-01-11.11.01.05.PM.webm
Screen.recording.2023-01-11.11.02.48.PM.webm

Environment

(please complete the following information):

  • browser type and version: Google Chrome Version 107.0.5304.110 (Official Build) (64-bit)
  • superset version: 2.0.1 (official docker image)
  • any feature flags active:
    "DASHBOARD_CROSS_FILTERS": True,
    "ALERT_REPORTS": True,
    "ENABLE_TEMPLATE_PROCESSING": True,
    "ENABLE_TEMPLATE_REMOVE_FILTERS": True,
    "GENERIC_CHART_AXES": True

Checklist

Make sure to follow these steps before submitting your issue - thank you!

  • [N/A] I have checked the superset logs for python stacktraces and included it here as text if there are any.
  • I have reproduced the issue with at least the latest released version of superset.
  • I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context

@saghatelian saghatelian added the #bug Bug report label Jan 11, 2023
@rusackas
Copy link
Member

Assigning to @kgabryje but I believe @geido is also looking at crossfilter related issues these days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
#bug Bug report
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants