-
Notifications
You must be signed in to change notification settings - Fork 13.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unwanted row number column appears in csv / excel while scheduling in email. #22981
Comments
I have tracked the issue but I am here stuck that both in the case of But got nothing , any suggestion realted to this bug |
@eschutho Can we stop PostProcessing from setting or from any other thing without modifing inside the code.?
|
Proposed Changes : It will facilitate a user user to chose that it wants index in csv or not while emailing through
2.
|
Thank you @Rohit-pawar902 for the issue and also the fix! We can implement what you suggested here, but you're also welcome to put up your own PR if you like. |
…l which is caused by post_processing.py and now it is Fixed (\apache#22981)
PR : #23155 |
Hey @Rohit-pawar902 ! Thanks for addressing the issue 👏 . I do have a couple of thoughts regarding this issue and how to address it though:
|
@Antonio-RiveroMartnez Actually previously I am not sure that it's really a bug or it is intentionally written like that , keeping this in mind I gave the opt in/out , so that someone wants the raw CSV or with index they can do that Now I would make changes keeping you issue in mind and treating as bug. |
@Antonio-RiveroMartnez |
Hey @Rohit-pawar902 ! Yes, you can make your changes in the same PR, there's no need for a new one, make sure tho, you update whatever feels necessary in the PR Template to fit your new scope, i.e, title, description, etc. |
@rohitpawar2811 / @Antonio-RiveroMartnez This one seems to have gotten away from it. Is there any work left to be done on the linked PR that would close this issue? |
It looks like the PR by @SkinnyPigeon is close to what we want here, but might need a volunteer to move the choice for including/excluding row indices from a config variable to a report modal config option. |
Hello
I am scheduling a chart(in table form) in email as csv form , I am getting an extra column which has a count from 0 to n-row .
Which I should not want.(And I think no one wants in CSV because we get numbering in csv opening platforms)
Like :
Findings :
Exactly I would say when the chart is in the form of bar/any other visualization except table then it will not add an extra column in csv while sending in email.
Using : superset-2.0.0-dev
My-Question :
@michael-s-molina @codyml
The text was updated successfully, but these errors were encountered: