-
Notifications
You must be signed in to change notification settings - Fork 13.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reloading of page with embedded dashboard leads to "Access is Denied"-popups before charts are shown (due to previous cookie) #23001
Comments
Yeah, this is very annoying and we were also clueless. Thanks for raising the bug. Hopefully we will have a fix soon. |
@lilykuang tried reproducing it and hasn't been able to yet. I think we're going to have to push this fix out to 2.1.1. Hopefully we can get someone to put up a fix for this. |
I added some notes to the additional context section above. |
Thanks @e-geist It looks like this may have been fixed in this PR. https://github.com/apache/superset/pull/21157/files. If you would like to test it out on the latest 2.1rc2 release, can you let us know if it fixes the issue for you? |
Hi @eschutho , sorry for the late response, will test as soon as possible and report back. |
So we were finally able to verify the fix. With 2.1rc3 we don't see any "Access Denied" messages popping up anymore! (Not sure what the policy about closing issues is? Do I close it or does it get closed?) |
I just added "can log on Superset" permission to Public role and that solved the problem for me. |
Yeah. Ever since I've included that permissions a couple of months ago, I haven't seen the "Access denied" toast for embedded dashboards. I think that is the one. |
Great. I'll close this ticket then. Thanks! |
If we reload a page (we created) with an embedded dashboard, that was successfully loaded before, "Access is Denied" popups appear in the upper right corner of the embedded dashboard. These disappear after some seconds and the dashboard is properly shown.
We noticed this happens, because the browser sends initially an "old cookie" from previous requests - Superset apparently tries using it and shows "Access is Denied".
These popups confuse users as the dashboard works fine, but there are some warnings shown.
There is also nothing the access is denied to, it's more of a cosmetic problem.
How to reproduce the bug
Expected results
Upon reloading of a page with an embedded dashboard, the dashboard is properly shown without warnings if there are no problems with authentication/role access.
Actual results
Upon reloading of a page with an embedded dashboard, "Access is Denied" warnings pop up before the actual dashboard is shown.
We would expect that even if the browser sends an old cookie, it is just discarded, as the provided guest token will be used anyways.
Environment
browser type and version: Firefox
superset version: 2.0.1
python version: Python 3.8.12
any feature flags active: nothing too special - we use embedding dashboards, but this also occurs for normal dashboards
Checklist
Make sure to follow these steps before submitting your issue - thank you!
Additional context
By manually deleting the session cookie of the superset instance, before reloading the page with the embedded dashboard, the warnings can be prevented. This is of course not feasible for end users.
Some further things to note:
The text was updated successfully, but these errors were encountered: