Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect filter scope when using tabs #24595

Closed
3 tasks done
michael-s-molina opened this issue Jul 5, 2023 · 1 comment · Fixed by #24608
Closed
3 tasks done

Incorrect filter scope when using tabs #24595

michael-s-molina opened this issue Jul 5, 2023 · 1 comment · Fixed by #24608
Assignees

Comments

@michael-s-molina
Copy link
Member

How to reproduce the bug

  1. Create a dashboard with one chart and one native filter that is applicable to that chart
  2. The filter is correctly displayed
  3. Edit the dashboard and add a tab with a chart of the same dataset
  4. The filter is now in out of scope filters and it shouldn't

Screenshots

Screen.Recording.2023-07-05.at.17.17.04.mov

Environment

  • superset version: master

Checklist

Make sure to follow these steps before submitting your issue - thank you!

  • I have checked the superset logs for python stacktraces and included it here as text if there are any.
  • I have reproduced the issue with at least the latest released version of superset.
  • I have checked the issue tracker for the same issue and I haven't found one similar.
@michael-s-molina
Copy link
Member Author

This problem happens when DASHBOARD_CROSS_FILTERS is enabled but DASHBOARD_NATIVE_FILTERS is not. The native filters are appearing but many of the required states are not correctly calculated because they depend on the feature flag. In this case, the filter scopes are not being correctly calculated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants