Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Incorrect dependency between filters related feature flags #24608

Merged
merged 2 commits into from
Jul 7, 2023
Merged

fix: Incorrect dependency between filters related feature flags #24608

merged 2 commits into from
Jul 7, 2023

Conversation

michael-s-molina
Copy link
Member

@michael-s-molina michael-s-molina commented Jul 6, 2023 •
edited

SUMMARY

This PR fixes incorrect dependencies between filters related feature flags. Specifically:

  • Makes DASHBOARD_CROSS_FILTERS independent of DASHBOARD_NATIVE_FILTERS. Previously, if DASHBOARD_NATIVE_FILTERS was disabled and DASHBOARD_CROSS_FILTERS was enabled, it would show native filters.
  • Makes DASHBOARD_NATIVE_FILTERS_SET dependent of DASHBOARD_NATIVE_FILTERS. Previously, if DASHBOARD_NATIVE_FILTERS_SET was enabled and DASHBOARD_NATIVE_FILTERS was disabled, it would lead to an inconsistent state because filter sets can't be applied if there are no native filters.

Closes #24595

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Recording showing the new relationship between the feature flags:

Screen.Recording.2023-07-06.at.15.00.28.mov

TESTING INSTRUCTIONS

1 - Enable/disable the mentioned feature flags using different combinations
2 - Make sure the elements are rendered according to the new feature flag relationship

ADDITIONAL INFORMATION

  • [] Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@michael-s-molina michael-s-molina added the v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch label Jul 6, 2023
kgabryje
kgabryje approved these changes Jul 7, 2023
View reviewed changes
Copy link
Member

@kgabryje kgabryje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@pull-request-size pull-request-size bot added size/L and removed size/M labels Jul 7, 2023
@michael-s-molina michael-s-molina merged commit 781a204 into apache:master Jul 7, 2023
26 checks passed
michael-s-molina added a commit that referenced this pull request Jul 26, 2023
@michael-s-molina
fix: Incorrect dependency between filters related feature flags (#24608)
26909bf 
(cherry picked from commit 781a204)
@mistercrunch mistercrunch added 🍒 3.0.0 🍒 3.0.1 🍒 3.0.2 🍒 3.0.3 🍒 3.0.4 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.1.0 labels Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgabryje kgabryje kgabryje approved these changes

@geido geido geido approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch 🍒 3.0.0 🍒 3.0.1 🍒 3.0.2 🍒 3.0.3 🍒 3.0.4 🚢 3.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect filter scope when using tabs
4 participants
@michael-s-molina @kgabryje @geido @mistercrunch