Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sankey diagram redraws on resize #254

Closed
andrewhn opened this issue Apr 4, 2016 · 2 comments
Closed

Sankey diagram redraws on resize #254

andrewhn opened this issue Apr 4, 2016 · 2 comments

Comments

@andrewhn
Copy link
Contributor

andrewhn commented Apr 4, 2016

OS: Ubuntu 14.04.4 LTS Server
Extra system info: Exhibited in FF and chrome
To reproduce: Select "Sankey" chart with appropriate data, render chart, resize window, see two sankey diagrams

Having trouble setting up a dev environment so I can't test but it seems like the sankey render function should clear the element before drawing, as the other d3 charts do (e.g. here).
@andrewhn andrewhn mentioned this issue Apr 4, 2016
Merged
@williaster
Copy link
Contributor

you're totally right, thanks for the issue, will fix.

for dev setup running npm install && npm run dev from the assets folder should work if you have node + npm installed?

@williaster williaster mentioned this issue Apr 4, 2016
Closed
@andrewhn
Copy link
Contributor Author

andrewhn commented Apr 5, 2016

Fixed with e3e8202

@andrewhn andrewhn closed this as completed Apr 5, 2016
jenseng added a commit to jenseng/superset-ui that referenced this issue Jul 14, 2021
@jenseng
fix(legacy-plugin-chart-sankey-loop): clear element before redrawing
6d2bbee 
otherwise every (re)render adds a new svg to the element. this is essentially
the same as the fix that was applied to legacy-plugin-chart-sankey back in
apache/superset#254
@jenseng jenseng mentioned this issue Jul 14, 2021
Merged
villebro pushed a commit to apache-superset/superset-ui that referenced this issue Aug 10, 2021
@jenseng
fix(legacy-plugin-chart-sankey-loop): clear element before redrawing (#…
29744d7 
…1223)

otherwise every (re)render adds a new svg to the element. this is essentially
the same as the fix that was applied to legacy-plugin-chart-sankey back in
apache/superset#254
graceguo-supercat pushed a commit to graceguo-supercat/superset that referenced this issue Oct 4, 2021
@kristw
feat(encodable): make applyDomain() able to handle domain from dataset (
6eb0b52 
apache#254)

* feat: make applyDomain() able to handle domain from dataset

* test: add unit tests

* fix: rename variable
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this issue Nov 17, 2021
@kristw @zhaoyongjie
feat(encodable): make applyDomain() able to handle domain from dataset (
fd701c9 
apache#254)

* feat: make applyDomain() able to handle domain from dataset

* test: add unit tests

* fix: rename variable
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this issue Nov 17, 2021
@jenseng @zhaoyongjie
fix(legacy-plugin-chart-sankey-loop): clear element before redrawing (a…
211d2d5 
…pache#1223)

otherwise every (re)render adds a new svg to the element. this is essentially
the same as the fix that was applied to legacy-plugin-chart-sankey back in
apache#254
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this issue Nov 24, 2021
@kristw @zhaoyongjie
feat(encodable): make applyDomain() able to handle domain from dataset (
8b1d042 
apache#254)

* feat: make applyDomain() able to handle domain from dataset

* test: add unit tests

* fix: rename variable
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this issue Nov 24, 2021
@jenseng @zhaoyongjie
fix(legacy-plugin-chart-sankey-loop): clear element before redrawing (a…
4acbaad 
…pache#1223)

otherwise every (re)render adds a new svg to the element. this is essentially
the same as the fix that was applied to legacy-plugin-chart-sankey back in
apache#254
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this issue Nov 25, 2021
@kristw @zhaoyongjie
feat(encodable): make applyDomain() able to handle domain from dataset (
c783877 
apache#254)

* feat: make applyDomain() able to handle domain from dataset

* test: add unit tests

* fix: rename variable
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this issue Nov 25, 2021
@jenseng @zhaoyongjie
fix(legacy-plugin-chart-sankey-loop): clear element before redrawing (a…
a1245ac 
…pache#1223)

otherwise every (re)render adds a new svg to the element. this is essentially
the same as the fix that was applied to legacy-plugin-chart-sankey back in
apache#254
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this issue Nov 26, 2021
@kristw @zhaoyongjie
feat(encodable): make applyDomain() able to handle domain from dataset (
f5f944b 
apache#254)

* feat: make applyDomain() able to handle domain from dataset

* test: add unit tests

* fix: rename variable
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this issue Nov 26, 2021
@jenseng @zhaoyongjie
fix(legacy-plugin-chart-sankey-loop): clear element before redrawing (a…
a4bc5ba 
…pache#1223)

otherwise every (re)render adds a new svg to the element. this is essentially
the same as the fix that was applied to legacy-plugin-chart-sankey back in
apache#254
This was referenced Jan 12, 2022
Closed
Open
Open
Open
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@andrewhn @williaster