Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clear sankey vis container on refresh to prevent duplicate charts. #257

Closed
wants to merge 2 commits into from
Closed

Clear sankey vis container on refresh to prevent duplicate charts. #257

wants to merge 2 commits into from

Conversation

williaster
Copy link
Contributor

Addresses issue 254. I prefer this over PR 255 to separate the logic more.

@mistercrunch

@landscape-bot
Copy link

Code Health
Code quality remained the same when pulling 8bdf10b on airbnb:chris/sankey-refresh into ca44432 on airbnb:master.

@landscape-bot
Copy link

Code Health
Code quality remained the same when pulling df57515 on airbnb:chris/sankey-refresh into ca44432 on airbnb:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 71.16% when pulling df57515 on chris/sankey-refresh into ca44432 on master.

@mistercrunch
Copy link
Member

Oh I'm surprised things get cleared when just rendering (not resizing). in other places I've been doing div.selectAll("*").remove();

@williaster
Copy link
Contributor Author

after talking in person let's hold off on this PR and I can look into the slice resize() calls and how different charts deal with it.

@mistercrunch mistercrunch deleted the chris/sankey-refresh branch November 9, 2016 22:24
graceguo-supercat pushed a commit to graceguo-supercat/superset that referenced this pull request Oct 4, 2021
@kristw
feat(encodable): handle edge cases when making domain includes zero (a…
1fc3ca0 
…pache#257)

* feat: handle edge cases when making domain includes zero

* test: remove redundant tests
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 17, 2021
@kristw @zhaoyongjie
feat(encodable): handle edge cases when making domain includes zero (a…
3d10b43 
…pache#257)

* feat: handle edge cases when making domain includes zero

* test: remove redundant tests
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 24, 2021
@kristw @zhaoyongjie
feat(encodable): handle edge cases when making domain includes zero (a…
2a9d400 
…pache#257)

* feat: handle edge cases when making domain includes zero

* test: remove redundant tests
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 25, 2021
@kristw @zhaoyongjie
feat(encodable): handle edge cases when making domain includes zero (a…
889d011 
…pache#257)

* feat: handle edge cases when making domain includes zero

* test: remove redundant tests
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 26, 2021
@kristw @zhaoyongjie
feat(encodable): handle edge cases when making domain includes zero (a…
e719c19 
…pache#257)

* feat: handle edge cases when making domain includes zero

* test: remove redundant tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@williaster @landscape-bot @coveralls @mistercrunch