-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sankey diagram redraws on resize #254
Comments
you're totally right, thanks for the issue, will fix. for dev setup running |
Fixed with e3e8202 |
jenseng
added a commit
to jenseng/superset-ui
that referenced
this issue
Jul 14, 2021
otherwise every (re)render adds a new svg to the element. this is essentially the same as the fix that was applied to legacy-plugin-chart-sankey back in apache/superset#254
villebro
pushed a commit
to apache-superset/superset-ui
that referenced
this issue
Aug 10, 2021
…1223) otherwise every (re)render adds a new svg to the element. this is essentially the same as the fix that was applied to legacy-plugin-chart-sankey back in apache/superset#254
graceguo-supercat
pushed a commit
to graceguo-supercat/superset
that referenced
this issue
Oct 4, 2021
apache#254) * feat: make applyDomain() able to handle domain from dataset * test: add unit tests * fix: rename variable
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this issue
Nov 17, 2021
apache#254) * feat: make applyDomain() able to handle domain from dataset * test: add unit tests * fix: rename variable
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this issue
Nov 17, 2021
…pache#1223) otherwise every (re)render adds a new svg to the element. this is essentially the same as the fix that was applied to legacy-plugin-chart-sankey back in apache#254
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this issue
Nov 24, 2021
apache#254) * feat: make applyDomain() able to handle domain from dataset * test: add unit tests * fix: rename variable
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this issue
Nov 24, 2021
…pache#1223) otherwise every (re)render adds a new svg to the element. this is essentially the same as the fix that was applied to legacy-plugin-chart-sankey back in apache#254
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this issue
Nov 25, 2021
apache#254) * feat: make applyDomain() able to handle domain from dataset * test: add unit tests * fix: rename variable
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this issue
Nov 25, 2021
…pache#1223) otherwise every (re)render adds a new svg to the element. this is essentially the same as the fix that was applied to legacy-plugin-chart-sankey back in apache#254
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this issue
Nov 26, 2021
apache#254) * feat: make applyDomain() able to handle domain from dataset * test: add unit tests * fix: rename variable
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this issue
Nov 26, 2021
…pache#1223) otherwise every (re)render adds a new svg to the element. this is essentially the same as the fix that was applied to legacy-plugin-chart-sankey back in apache#254
This was referenced Jan 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
OS: Ubuntu 14.04.4 LTS Server
Extra system info: Exhibited in FF and chrome
To reproduce: Select "Sankey" chart with appropriate data, render chart, resize window, see two sankey diagrams
Having trouble setting up a dev environment so I can't test but it seems like the sankey render function should clear the element before drawing, as the other d3 charts do (e.g. here).
The text was updated successfully, but these errors were encountered: