Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bar chart with numeric x-axis always starts x-axis at zero regardless of data #26139

Closed
2 of 3 tasks
sfirke opened this issue Nov 29, 2023 · 5 comments · Fixed by #26215
Closed
2 of 3 tasks

Bar chart with numeric x-axis always starts x-axis at zero regardless of data #26139

sfirke opened this issue Nov 29, 2023 · 5 comments · Fixed by #26215
Assignees
Labels
validation:validated A committer has validated / submitted the issue or it was reported by multiple users

Comments

@sfirke
Copy link
Member

sfirke commented Nov 29, 2023

Trying out 3.1.0rc1 I noticed that one of my bar charts looked wrong.

In version 3.0.0:

image

In version 3.1.0rc1:
image

I tried making a new chart with another dataset where I have year as a numeric and I experienced the same thing, though the x-axis terminated around 2500 instead of 7000 in the screenshot above.

Environment

GENERIC_CHART_AXES is enabled

Checklist

Make sure to follow these steps before submitting your issue - thank you!

  • I have checked the superset logs for python stacktraces and included it here as text if there are any.
  • I have reproduced the issue with at least the latest released version of superset.
  • I have checked the issue tracker for the same issue and I haven't found one similar.
@sfirke sfirke added the validation:validated A committer has validated / submitted the issue or it was reported by multiple users label Dec 1, 2023
@john-bodley
Copy link
Member

@sfirke I am unable to repo this on the 3.1 branch from the examples. Have you been able to replicate the behavior there and/or do you have any chart level overrides applied (defined under the CUSTOMIZE tab)?

@sfirke
Copy link
Member Author

sfirke commented Dec 4, 2023

The only override I have on that tab is Stacked Style = Stack. The problem persists when I disable that. I'll try to reproduce on the 3.1 ephemeral, in the meantime here's my chart config:
image

@sfirke
Copy link
Member Author

sfirke commented Dec 4, 2023

I reproduced it in the test ephemeral environment at http://54.188.107.61:8080, the chart title is Reproduce x-axis issue 26139. I took the video game data set (in which year was marked temporal), cast it as an integer as a new column called year_int, and created a chart with year_int on the x-axis.

@michael-s-molina
Copy link
Member

@villebro do you think this is related to #26087?

@villebro
Copy link
Member

villebro commented Dec 4, 2023

@michael-s-molina this is indeed likely related to that PR. Let me take a look at what could be causing this - thanks @sfirke for creating the repro case, very helpful!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
validation:validated A committer has validated / submitted the issue or it was reported by multiple users
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants