Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugin-chart-echarts): support numerical x-axis #26087

Merged
merged 1 commit into from
Nov 24, 2023

Conversation

villebro
Copy link
Member

SUMMARY

Currently using a numeric x-axis produces a chart with a categorical x-axis. This sets the x-axis to

AFTER

Now the x-axis is numerical:
image

BEFORE

Previously the x-axis was set as categorical:
image

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

Copy link
Member

@zhaoyongjie zhaoyongjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Nov 23, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (dd58b31) 69.07% compared to head (fd05b38) 69.07%.
Report is 23 commits behind head on master.

Files Patch % Lines
...gin-chart-echarts/src/Timeseries/transformProps.ts 0.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master   #26087   +/-   ##
=======================================
  Coverage   69.07%   69.07%           
=======================================
  Files        1941     1941           
  Lines       75882    75885    +3     
  Branches     8443     8445    +2     
=======================================
+ Hits        52412    52416    +4     
+ Misses      21295    21294    -1     
  Partials     2175     2175           
Flag Coverage Δ
javascript 56.28% <50.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@villebro villebro merged commit aad67e4 into apache:master Nov 24, 2023
31 checks passed
@michael-s-molina michael-s-molina added the v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch label Nov 28, 2023
@villebro villebro deleted the villebro/numerical-x-axis branch November 28, 2023 17:11
michael-s-molina pushed a commit that referenced this pull request Dec 4, 2023
sadpandajoe added a commit to preset-io/superset that referenced this pull request Dec 22, 2023
josedev-union pushed a commit to Ortege-xyz/studio that referenced this pull request Jan 22, 2024
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch mistercrunch added 🍒 3.0.3 🍒 3.0.4 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.1.0 labels Mar 8, 2024
sfirke pushed a commit to sfirke/superset that referenced this pull request Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch 🍒 3.0.3 🍒 3.0.4 🚢 3.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Regression] GENERIC_CHART_AXES: numeric x-axis treated as categorical values
5 participants