ROW_LIMIT not working

[mujohiddin]

Bug description

Hello there. my project is last year september october version but i have row limit not working how to fix it. I don't know how to fix it. Help me pleace

How to reproduce the bug

1

Screenshots/recordings

@michael-s-molina @betodealmeida @rusackas @jon

Superset version

master / latest-dev

Python version

3.9

Node version

16

Browser

Chrome

Additional context

Hi

Checklist

• I have searched Superset docs and Slack and didn't find a solution to my problem.
• I have searched the GitHub issue tracker and didn't find a similar bug report.
• I have checked Superset's logs for errors and if I found a relevant Python stacktrace, I included it here as text in the "additional context" section.

[dosubot]

The issue you're experiencing with the "ROW_LIMIT" setting not being applied correctly could be due to several factors, including recent changes in the Superset codebase, backend configurations, or frontend control logic. Here are some steps and considerations to help you resolve this issue:

Backend Configurations

Ensure that the backend configurations in config.py are not overriding your "ROW_LIMIT" setting. Key settings to check include:

• SQL_MAX_ROW: Defines the maximum number of rows returned for any analytical database query.
• DISPLAY_MAX_ROW: Limits the number of rows displayed in the SQL Lab UI.
• DEFAULT_SQLLAB_LIMIT: Default row limit for SQL Lab queries.
• SUPERSET_META_DB_LIMIT: Limit when the feature flag ENABLE_SUPERSET_META_DB is on.
• SQLLAB_CTAS_NO_LIMIT: Allows SQL Lab to run queries without a row limit when using the CTAS feature.

Frontend Control Logic

Ensure that the value you set (20,000,000) is within the allowed options or is correctly validated as a free-form input. The row_limit control is defined with specific options and validation logic.

Recent Changes in Superset Codebase

There have been recent changes in the Superset codebase that might affect the "ROW_LIMIT" setting. Notably, pull requests #27700 and #26151 address issues related to row limits.

Logging and Debugging

Superset has logging mechanisms that can help trace how the "ROW_LIMIT" setting is being applied or ignored during query execution. Key logging statements are present in the superset/commands/sql_lab/execute.py file.

Visibility of row_limit Control

Ensure that the server_pagination control is not enabled, as it might be causing the "ROW_LIMIT" setting to be ignored.

If the problem persists, consider reviewing the recent changes in the Superset codebase that might affect the behavior of the "ROW_LIMIT" setting.

It seems like this issue requires a deeper look, @rusackas could you please lend your expertise?

Details

Sources

• Limit issue
• superset/migrations/versions/2019-06-04_10-12_d7c1a0d6f2da_remove_limit_used_from_query_model.py
• superset-frontend/plugins/plugin-chart-handlebars/src/plugin/controls/limits.ts
• superset-frontend/src/explore/controls.jsx
• superset/config.py
• docker/pythonpath_dev/superset_config.py
• superset/sql_lab.py
• superset/commands/sql_lab/execute.py
• CHANGELOG/3.1.0.md
• CHANGELOG/4.0.1.md
• superset-frontend/packages/superset-ui-chart-controls/src/shared-controls/sharedControls.tsx
• superset-frontend/src/SqlLab/components/ResultSet/index.tsx

About Dosu
This response is meant to be useful and save you time. It is not meant to be a precise solution, but rather a starting point for your own research.

Help me be more useful! Please leave a 👍 if this is helpful and 👎 if it is irrelevant.

To continue the conversation, mention @dosu.

[mujohiddin]

I have run my superset project version for the first time since September October last year, I tried the above solutions and it didn't work
@dosu._

[dosubot]

It seems like this issue requires a deeper look. @rusackas, could you please lend your expertise?

Details

About Dosu
This response is meant to be useful and save you time. It is not meant to be a precise solution, but rather a starting point for your own research.

Help me be more useful! Please leave a 👍 if this is helpful and 👎 if it is irrelevant.

To continue the conversation, mention @dosu.

[gaful]

Hello, you mentionned a september / october version. I recalled we faced the same issue around the same period, it was solved for us since 3.1.3.

[michael-s-molina]

Ho @mujohiddin. This bug was fixed by #26807 which is available in 3.1.3 and 4.0.1 so you just need to use one of these versions. You can always check in which version a fix is available using the CHANGELOG.

FYI: It's not a good practice to tag multiple people multiple times. Keep in mind that we receive many messages every day and might be busy resolving other issues.