Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(chart): Set max row limit + removed the option to use an empty row limit value #26151

Merged
merged 25 commits into from
Dec 27, 2023

Conversation

CorbinBullard
Copy link
Contributor

SUMMARY

  • Can no longer clear/remove the row limit
  • New validator that checks if a value is larger than a given input
  • Removed ValidateNonEmpty() validator that was causing charts before the update not to render

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:
Row Limit 1
Row Limit 2
After:
Screenshot 2023-10-09 120420
Screenshot 2023-10-09 120447

@john-bodley john-bodley requested review from diegomedina248 and geido and removed request for diegomedina248 December 1, 2023 18:06
@john-bodley
Copy link
Member

Thanks @CorbinBullard for the PR. Is this recreation of a previous PR? If so would you mind linking said PR in the PR description to help provide context/lineage.

@CorbinBullard
Copy link
Contributor Author

Here is the original PR that was reverted #25579

Copy link

codecov bot commented Dec 1, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9d37968) 69.18% compared to head (7edb455) 69.19%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #26151      +/-   ##
==========================================
+ Coverage   69.18%   69.19%   +0.01%     
==========================================
  Files        1945     1946       +1     
  Lines       75970    75920      -50     
  Branches     8467     8469       +2     
==========================================
- Hits        52558    52533      -25     
+ Misses      21225    21200      -25     
  Partials     2187     2187              
Flag Coverage Δ
javascript 56.53% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The max value should come from SQL_MAX_ROW and not be a fixed 100,000.

@pull-request-size pull-request-size bot added size/M and removed size/L labels Dec 19, 2023
lilykuang and others added 3 commits December 19, 2023 13:03
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rusackas rusackas merged commit 863f8bb into apache:master Dec 27, 2023
30 checks passed
@michael-s-molina michael-s-molina added v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch v3.1 Label added by the release manager to track PRs to be included in the 3.1 branch labels Dec 27, 2023
michael-s-molina added a commit that referenced this pull request Dec 27, 2023
…w limit value (#26151)

Co-authored-by: Lily Kuang <lily@preset.io>
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
michael-s-molina added a commit that referenced this pull request Dec 27, 2023
…w limit value (#26151)

Co-authored-by: Lily Kuang <lily@preset.io>
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
josedev-union pushed a commit to Ortege-xyz/studio that referenced this pull request Jan 22, 2024
…w limit value (apache#26151)

Co-authored-by: Lily Kuang <lily@preset.io>
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
@Stefan781
Copy link

Stefan781 commented Jan 23, 2024

Using Superset 3.1, I am limited to 100 000 rows even if I set both SQL_MAX_ROW and ROW_LIMIT. Is that the expected behavior? How can I set a higher limit?
EDIT: Setting it to below 100 000 results in the same limit.

@Stefan781
Copy link

I debugged further. For that, I had to use an already existing chart that had a limit of more than 100 000 prior to the upgrade to 3.1.
Changing the SQL_MAX_ROW to 5000 results in a proper LIMIT 5000; in the query. Bringing it back up updates the value accordingly, up until the chart's original row limit. However, the check is still kept to 100 000 when creating the chart. This points to an issue with those changes. Could somebody confirm?

@michael-s-molina michael-s-molina mentioned this pull request Jan 25, 2024
9 tasks
@mistercrunch mistercrunch added 🍒 3.0.3 🍒 3.0.4 🍒 3.1.0 🍒 3.1.1 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels labels Mar 8, 2024
sfirke pushed a commit to sfirke/superset that referenced this pull request Mar 22, 2024
…w limit value (apache#26151)

Co-authored-by: Lily Kuang <lily@preset.io>
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
@dosubot dosubot bot mentioned this pull request May 23, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch v3.1 Label added by the release manager to track PRs to be included in the 3.1 branch 🍒 3.0.3 🍒 3.0.4 🍒 3.1.0 🍒 3.1.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants