Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support number right-aligning in table view #2933

Closed
SimpleExpress opened this issue Jun 9, 2017 · 1 comment · Fixed by #2943
Closed

support number right-aligning in table view #2933

SimpleExpress opened this issue Jun 9, 2017 · 1 comment · Fixed by #2943

Comments

@SimpleExpress
Copy link

This is an improvement suggestion.

Superset version

15.2

Expected results

numbers should be either right-aligned or decimal places aligned, it's better that user can control this behavior.

Actual results

numbers in table view are left-aligned like normal text, which is not so convenient for comparison.

Steps to reproduce

create a table view with any metrics, number values are now left-aligned and I could not found any adjustment for it. I also tried d3-format with padding but this doesn't work.

@xrmx
Copy link
Contributor

xrmx commented Jun 9, 2017

Does it happen on latest release?

mistercrunch added a commit to mistercrunch/superset that referenced this issue Jun 11, 2017
Moved the histogram to be rooted on the right side as well

fixes apache#2933
mistercrunch added a commit that referenced this issue Jun 12, 2017
Moved the histogram to be rooted on the right side as well

fixes #2933
graceguo-supercat pushed a commit to graceguo-supercat/superset that referenced this issue Jun 13, 2017
Moved the histogram to be rooted on the right side as well

fixes apache#2933
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants