Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

using slice_id instead of url to do caching #547

Closed
wants to merge 2 commits into from
Closed

using slice_id instead of url to do caching #547

wants to merge 2 commits into from

Conversation

yxjames
Copy link
Contributor

@yxjames yxjames commented Jun 1, 2016

I use slice_id as the cache key. When slices are cached from dashboard I add manually add slice_id into form_data since sometimes form_data['slice_id'] is empty.

@coveralls
Copy link

coveralls commented Jun 1, 2016

Coverage Status

Coverage increased (+0.02%) to 82.127% when pulling 0ff5ec7 on joshwalters:dashboard_cache into 087c47a on airbnb:master.

@yxjames
Copy link
Contributor Author

yxjames commented Jun 1, 2016

If the slice is accessed from dashboard, form_data['slice_id'] is empty until the user overwrite that slice. I don't know if this is designed for some purpose. Any idea?

@coveralls
Copy link

coveralls commented Jun 1, 2016

Coverage Status

Coverage increased (+0.02%) to 82.127% when pulling f7e974e on joshwalters:dashboard_cache into 087c47a on airbnb:master.

@mistercrunch
Copy link
Member

I don't think this works where filter widget is used.

zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 17, 2021
apache#547)

* feat: update functions

* test: add unit tests

* fix: unit tests

* fix: address comments and use piecewise
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 24, 2021
apache#547)

* feat: update functions

* test: add unit tests

* fix: unit tests

* fix: address comments and use piecewise
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 25, 2021
apache#547)

* feat: update functions

* test: add unit tests

* fix: unit tests

* fix: address comments and use piecewise
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 26, 2021
apache#547)

* feat: update functions

* test: add unit tests

* fix: unit tests

* fix: address comments and use piecewise
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants