[explore] moving the timer from a button to a label #1010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mistercrunch
commented
Aug 24, 2016
•
mistercrunch
commented
| @@ -14,10 +14,10 @@ | |||
| @gray-light: lighten(@gray-base, 70%); // | |||
| @gray-lighter: lighten(@gray-base, 90%); // #eee | |||
|
|
|||
| @brand-primary: #515152; | |||
| @brand-primary: darken(#45A5FF, 25%); | |||
There was a problem hiding this comment.
reviewed with this with eli too, let's use the brighter airpal blue. #45A5FF
|
can you make your timer change in another pr? it's a lot easier to track than adding on to my pr. |
mistercrunch
force-pushed
the
ascott-btn-colors-2
branch
3 times, most recently
from
a94a745
to
595915b
Compare
mistercrunch
changed the title
|
@ascott done! |
mistercrunch
force-pushed
the
ascott-btn-colors-2
branch
from
595915b
to
ef8e52b
Compare
|
thanks! 🚢 |
mistercrunch
force-pushed
the
ascott-btn-colors-2
branch
from
ef8e52b
to
d17efca
Compare
| </button> | ||
| <button | ||
| type="button" | ||
| className={saveClasses} | ||
| data-target="#save_modal" | ||
| data-toggle="modal" | ||
| > | ||
| <i className="fa fa-plus-circle"></i>Save as | ||
| <i className="fa fa-plus-circle"></i> Save as |
There was a problem hiding this comment.
just a question, why do you need a space in the button name?
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 17, 2021
…pache#1010) * feat(plugin-chart-echarts): emit filter events when clicking on slice * feat(plugin-chart-echarts): enable emitting filter * clean up filter state * check eventHandlers by emitFilter flag * feat(plugin-chart-echarts): multiple choices for filter * WIP * feat(plugin-chart-echarts): select multiple values * add conditional control item for emitting filter * add cross filter for box plot chart * refactor: combine values and indexes single object * fix: eslint * Add default emitFilter for BoxPlot. Check emit filter before handle crossFilter Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 24, 2021
…pache#1010) * feat(plugin-chart-echarts): emit filter events when clicking on slice * feat(plugin-chart-echarts): enable emitting filter * clean up filter state * check eventHandlers by emitFilter flag * feat(plugin-chart-echarts): multiple choices for filter * WIP * feat(plugin-chart-echarts): select multiple values * add conditional control item for emitting filter * add cross filter for box plot chart * refactor: combine values and indexes single object * fix: eslint * Add default emitFilter for BoxPlot. Check emit filter before handle crossFilter Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 25, 2021
…pache#1010) * feat(plugin-chart-echarts): emit filter events when clicking on slice * feat(plugin-chart-echarts): enable emitting filter * clean up filter state * check eventHandlers by emitFilter flag * feat(plugin-chart-echarts): multiple choices for filter * WIP * feat(plugin-chart-echarts): select multiple values * add conditional control item for emitting filter * add cross filter for box plot chart * refactor: combine values and indexes single object * fix: eslint * Add default emitFilter for BoxPlot. Check emit filter before handle crossFilter Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 26, 2021
…pache#1010) * feat(plugin-chart-echarts): emit filter events when clicking on slice * feat(plugin-chart-echarts): enable emitting filter * clean up filter state * check eventHandlers by emitFilter flag * feat(plugin-chart-echarts): multiple choices for filter * WIP * feat(plugin-chart-echarts): select multiple values * add conditional control item for emitting filter * add cross filter for box plot chart * refactor: combine values and indexes single object * fix: eslint * Add default emitFilter for BoxPlot. Check emit filter before handle crossFilter Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.