Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(permissions): alpha role has all full features #10241

Merged
merged 10 commits into from
Jul 27, 2020
Merged

fix(permissions): alpha role has all full features #10241

Changes from 5 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
7e5fb84
fix(permissions): alpha role is inconsistent
dpgaspar Jul 3, 2020
4810828
reverse and allow Alpha to access manager menu
dpgaspar Jul 6, 2020
db0abf0
Merge branch 'master' into fix/alpha-perms
dpgaspar Jul 10, 2020
d2244a9
Bump FAB to 3.0.1rc1 to include del permission fix
dpgaspar Jul 10, 2020
55c5ef2
Merge branch 'master' into fix/alpha-perms
dpgaspar Jul 17, 2020
631c97e
add docs, tests and UPDATING
dpgaspar Jul 27, 2020
ee9acfb
Merge remote-tracking branch 'origin/fix/alpha-perms' into fix/alpha-…
dpgaspar Jul 27, 2020
b38ce23
EOL
dpgaspar Jul 27, 2020
766f14a
Fix query view for Alpha
dpgaspar Jul 27, 2020
ccb0a55
Merge branch 'master' into fix/alpha-perms
dpgaspar Jul 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions superset/security/manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,6 @@ class SupersetSecurityManager( # pylint: disable=too-many-public-methods

ADMIN_ONLY_VIEW_MENUS = {
"AccessRequestsModelView",
"Manage",
"SQL Lab",
"Queries",
"Refresh Druid Metadata",
Expand All @@ -139,7 +138,13 @@ class SupersetSecurityManager( # pylint: disable=too-many-public-methods
"RowLevelSecurityFiltersModelView",
} | USER_MODEL_VIEWS

ALPHA_ONLY_VIEW_MENUS = {"Upload a CSV"}
ALPHA_ONLY_VIEW_MENUS = {
dpgaspar marked this conversation as resolved.
Show resolved Hide resolved
"Manage",
"CSS Templates",
"Queries",
"Import dashboards",
"Upload a CSV",
}

ADMIN_ONLY_PERMISSIONS = {
"can_sql_json", # TODO: move can_sql_json to sql_lab role
Expand Down