Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update delete modal for dataset #10258

Merged
merged 3 commits into from Jul 10, 2020
Merged

feat: update delete modal for dataset #10258

merged 3 commits into from Jul 10, 2020

Conversation

lilykuang
Copy link
Member

SUMMARY

  • implement the Delete modal to match UI closer to SIP-34
  • warns user about related charts and dashboard
  • user need to type 'DELETE' before being able to delete the dataset

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

AFTER
https://www.loom.com/share/79bf03bccdea498ab6c0531494f29271

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@pull-request-size pull-request-size bot added size/XL and removed size/L labels Jul 9, 2020
@lilykuang lilykuang marked this pull request as ready for review July 9, 2020 02:00
suddjian
suddjian reviewed Jul 9, 2020
View reviewed changes
superset-frontend/src/components/DeleteModal.tsx
title: React.ReactNode;
}

export default function DeleteModal({
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea to bring this out to a separate component, this is cleaner

@willbarrett willbarrett requested a review from nytai July 9, 2020 16:59
suddjian
suddjian approved these changes Jul 9, 2020
View reviewed changes
Copy link
Member

@suddjian suddjian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lilykuang lilykuang closed this Jul 10, 2020
@lilykuang lilykuang reopened this Jul 10, 2020
@suddjian suddjian merged commit 80b06f6 into apache:master Jul 10, 2020
@suddjian suddjian deleted the lily/delete-modal branch July 10, 2020 21:23
@suddjian suddjian restored the lily/delete-modal branch July 10, 2020 21:23
@suddjian suddjian deleted the lily/delete-modal branch July 10, 2020 21:23
auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
@lilykuang @auxten
feat: update delete modal for dataset (apache#10258)
d61e9a8 
* update delete modal for dataset

* update datasetList to use hooks

* fix typo on dataset delete modal
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.37.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suddjian suddjian suddjian approved these changes

@nytai nytai Awaiting requested review from nytai

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XL 🚢 0.37.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lilykuang @suddjian @mistercrunch