fix(chart-data-api): case insensitive evaluation of filter op #10299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
villebro
changed the title
dpgaspar
reviewed
Jul 13, 2020
superset/utils/schema.py
Outdated
|
|
||
| def __call__(self, value: Any) -> str: | ||
| try: | ||
| print(value) |
There was a problem hiding this comment.
print here is probably a debug left over
6 tasks
Codecov Report
@@ Coverage Diff @@
## master #10299 +/- ##
==========================================
+ Coverage 70.42% 70.63% +0.20%
==========================================
Files 599 600 +1
Lines 32067 32102 +35
Branches 3244 3244
==========================================
+ Hits 22583 22675 +92
+ Misses 9380 9325 -55
+ Partials 104 102 -2
Continue to review full report at Codecov.
|
dpgaspar
approved these changes
Jul 13, 2020
villebro
added a commit
that referenced
this pull request
Jul 14, 2020
* fix(chart-data-api): case insensitive evaluation of filter op * fix(chart-data-api): case insensitive evaluation of filter op * mypy * remove print statement * add test
auxten
pushed a commit
to auxten/incubator-superset
that referenced
this pull request
Nov 20, 2020
…#10299) * fix(chart-data-api): case insensitive evaluation of filter op * fix(chart-data-api): case insensitive evaluation of filter op * mypy * remove print statement * add test
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
…#10299) * fix(chart-data-api): case insensitive evaluation of filter op * fix(chart-data-api): case insensitive evaluation of filter op * mypy * remove print statement * add test
mistercrunch
added
🍒 0.37.0
🍒 0.37.1
🍒 0.37.2
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Introduce case insensitive validation of filter operators in chart data schemas, as filter operators are made uppercase in both Druid and SQLA connectors, hence case isn't a concern for queries. The custom validators are moved to
utils/schema.pyas they will likely be relevant in other endpoints, too.Currently the cases of filter operators are inconsistent: some are all uppercase, others all lowercase. I considered unifying those, but it would have introduced risk of regression, so will save that for a separate PR after 0.37.0 has shipped.
BEFORE
AFTER
TEST PLAN
CI + new tests
ADDITIONAL INFORMATION