Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bump nvd3 plugin for pie chart label type #10430

Merged
merged 1 commit into from Jul 27, 2020
Merged

fix: bump nvd3 plugin for pie chart label type #10430

merged 1 commit into from Jul 27, 2020

Conversation

stuarthu
Copy link
Contributor

@stuarthu stuarthu commented Jul 27, 2020

SUMMARY

Fixes apache-superset/superset-ui#697

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

截屏2020-07-27 09 21 33

TEST PLAN

CI

ADDITIONAL INFORMATION

@stuarthu stuarthu changed the title fix: bump nvd3 plugin for pie chart label type [WIP] fix: bump nvd3 plugin for pie chart label type Jul 27, 2020
@stuarthu stuarthu changed the title [WIP] fix: bump nvd3 plugin for pie chart label type fix: bump nvd3 plugin for pie chart label type Jul 27, 2020
@stuarthu
Copy link
Contributor Author

@ktmud @mistercrunch This is to update nvd3 plugin in superset for pie chart label type.

@villebro
Copy link
Member

@stuarthu you need to rebase to fix a conflict in the lock file.

Signed-off-by: Stuart Hu <shijiehu@improbable.io>
@stuarthu
Copy link
Contributor Author

@stuarthu you need to rebase to fix a conflict in the lock file.

done

@villebro villebro merged commit f746590 into apache:master Jul 27, 2020
@stuarthu stuarthu deleted the bump_nvd3 branch July 27, 2020 10:26
villebro pushed a commit to preset-io/superset that referenced this pull request Aug 20, 2020
Signed-off-by: Stuart Hu <shijiehu@improbable.io>
craig-rueda pushed a commit to preset-io/superset that referenced this pull request Aug 24, 2020
Signed-off-by: Stuart Hu <shijiehu@improbable.io>
villebro pushed a commit that referenced this pull request Sep 5, 2020
Signed-off-by: Stuart Hu <shijiehu@improbable.io>
villebro pushed a commit that referenced this pull request Sep 16, 2020
Signed-off-by: Stuart Hu <shijiehu@improbable.io>
auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
Signed-off-by: Stuart Hu <shijiehu@improbable.io>
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
Signed-off-by: Stuart Hu <shijiehu@improbable.io>
@mistercrunch mistercrunch added 🍒 0.37.2 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.38.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS v0.37 v0.37.2 🍒 0.37.2 🚢 0.38.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support show both value and percentage on pie chart
3 participants