Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: SubMenu css #10682

Merged
merged 1 commit into from
Aug 26, 2020
Merged

fix: SubMenu css #10682

merged 1 commit into from
Aug 26, 2020

Conversation

nytai
Copy link
Member

@nytai nytai commented Aug 26, 2020

SUMMARY

There's an issue with the css on the SubMenu component. Likely due to the recent menu changes.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:
Screen Shot 2020-08-26 at 12 11 00 AM

After:
Screen Shot 2020-08-26 at 12 10 00 AM

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@nytai nytai mentioned this pull request Aug 26, 2020
Merged
6 tasks
@nytai nytai closed this Aug 26, 2020
@nytai nytai reopened this Aug 26, 2020
@nytai nytai requested a review from rusackas August 26, 2020 19:26
rusackas
rusackas approved these changes Aug 26, 2020
View reviewed changes
Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nytai nytai merged commit bc0fc4e into apache:master Aug 26, 2020
@nytai nytai deleted the tai/fix-menu branch August 26, 2020 21:00
@villebro villebro added the v0.38 label Sep 10, 2020
villebro pushed a commit to preset-io/superset that referenced this pull request Sep 11, 2020
@nytai @villebro
fix: SubMenu css (apache#10682)
597ef34
villebro pushed a commit that referenced this pull request Sep 11, 2020
@nytai @villebro
fix: SubMenu css (#10682)
f8bdf5e
Ofeknielsen pushed a commit to ofekisr/incubator-superset that referenced this pull request Oct 5, 2020
@nytai
fix: SubMenu css (apache#10682)
834b40c
auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
@nytai @auxten
fix: SubMenu css (apache#10682)
f32b49e
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.38.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rusackas rusackas rusackas approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS v0.38 🚢 0.38.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nytai @rusackas @mistercrunch @villebro