feat: server side dashboard css for less repaint #10850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nytai
approved these changes
Sep 12, 2020
Codecov Report
@@ Coverage Diff @@
## master #10850 +/- ##
==========================================
- Coverage 65.46% 60.98% -4.49%
==========================================
Files 809 809
Lines 38154 38152 -2
Branches 3605 3605
==========================================
- Hits 24979 23266 -1713
- Misses 13066 14700 +1634
- Partials 109 186 +77
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
ktmud
force-pushed
the
earlier-dashboard-css
branch
from
a2b55f5
to
984b5e2
Compare
ktmud
commented
Sep 12, 2020
| {{ super() }} | ||
| {% if custom_css %} | ||
| <style class="CssEditor-css" type="text/css"> | ||
| {{ custom_css }} |
There was a problem hiding this comment.
malicious strings should be escaped by Jinja.
| {% block head_css %} | ||
| {{ super() }} | ||
| {% if custom_css %} | ||
| <style class="CssEditor-css" type="text/css"> |
There was a problem hiding this comment.
Must add this class so that live-edits can updating previous CSS.
ktmud
force-pushed
the
earlier-dashboard-css
branch
from
984b5e2
to
9f33735
Compare
ktmud
force-pushed
the
earlier-dashboard-css
branch
from
9f33735
to
f434b22
Compare
auxten
pushed a commit
to auxten/incubator-superset
that referenced
this pull request
Nov 20, 2020
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Add custom dashboard css to server side rendering so the page doesn't have to repaint when refresh.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before
Since custom CSS is added after dashboard is loaded, when loading a dashboard, you may see an annoying repaint:
After
No repaint when refreshing the page:
TEST PLAN
Manual testing.
ADDITIONAL INFORMATION