style: fix checkbox color #10970
Merged
style: fix checkbox color #10970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mistercrunch
commented
Sep 20, 2020
•
mistercrunch
commented
|
Max, is this PR related to #10799 ? Replaces the use of font-awesome for checkboxes with the svg components that already exist. |
rusackas
approved these changes
Sep 21, 2020
|
Yes @junlinc it's related, it's just fixing the color |
Codecov Report
@@ Coverage Diff @@
## master #10970 +/- ##
==========================================
- Coverage 65.85% 61.37% -4.49%
==========================================
Files 815 815
Lines 38324 38336 +12
Branches 3600 3599 -1
==========================================
- Hits 25238 23528 -1710
- Misses 12984 14622 +1638
- Partials 102 186 +84
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
amitmiran137
pushed a commit
to ofekisr/incubator-superset
that referenced
this pull request
Sep 22, 2020
…l_access/dashboard_by_id_endpoints * upstream/master: (29 commits) fix(presto): default unknown types to string type (apache#10753) feat(row-level-security): add base filter type and filter grouping (apache#10946) docs: add gallery screenshot & link in README (apache#10988) docs: add a "Gallery" page (apache#10968) build: add PR lint action (apache#10990) adding filters back that caused issues (apache#10989) chore: selectors refactor in SQLLab test suite (Cypress) (apache#10944) ESLint: Remove ts-ignore comments (apache#10933) style: fix checkbox color (apache#10970) fix: changed disabled rules in datasets module (apache#10979) fix: update the time filter for 'Last Year' option in explore (apache#10829) fix: use nullpool even for user lookup in the celery (apache#10938) Allow empty observations in alerting (apache#10939) fix: re-enabling several globally disabled lint rules (apache#10957) fix: setting specific exceptions common/query_context.py (apache#10942) Pylint disabled rule `pointless-string-statement` is not raising warining anymore - removing (apache#10975) fix: pylint disabled rules in dashboard/api.py (apache#10976) fix: removed disabled lint rule `too-many-locals` in connectors/base/models.py (apache#10958) ESLint: Re-enable rule no-access-state-in-setstate (apache#10870) fix: simply is_adhoc_metric (apache#10964) ...
3 tasks
|
this PR breaks the filter_box control: |
graceguo-supercat
pushed a commit
to airbnb/superset-fork
that referenced
this pull request
Sep 24, 2020
graceguo-supercat
pushed a commit
that referenced
this pull request
Sep 24, 2020
This reverts commit e4e78b6.
graceguo-supercat
pushed a commit
that referenced
this pull request
Sep 24, 2020
amitmiran137
pushed a commit
to ofekisr/incubator-superset
that referenced
this pull request
Sep 27, 2020
…boards_permissions * upstream/master: (46 commits) fix: surface connection error messages on the client (apache#11077) fix(jest): using UTC mock date (apache#11079) removing unused component (apache#11072) changing to the correct hex color (apache#11073) style: remove unecessary padding (apache#11071) fix: database list checkboxes (apache#11068) feat: adding all icons from the design system to the codebase (apache#11033) fix: sql lab autocomplete width (apache#11063) clickable labels have outlines, storybook shows them (apache#11034) fixed routes for customer in docs (apache#11052) Revert "style: fix checkbox color (apache#10970)" (apache#11051) feat: add "created by" to dashboard CRUD view (apache#11030) Changed `tags.py` and `helpers.py` in `models` module: removed disabled pylint rule `unused_import`, changed unused arguments to private and removed disabled rule `unused-argument. Removed redundant rules.` (apache#11037) chore: updated lint rules in models module (apache#11036) Removed disable global pytlint rule `standarderror-builtin` which isn't appearing for Python3 (apache#11038) Enabled argument-differ for bulk_delete (apache#11039) Enabled no-self-use pylint rule in security. Formatter (apache#11041) Changed variable name from capitals to lowercase and changed lint rule (apache#11044) Revert "ESLint: Re-enable rule default-props-match-prop-types (apache#10868)" (apache#11050) feat(saved_queries): add custom api filter for all string & text fields (apache#11031) ... # Conflicts: # superset/config.py # tests/dashboards/api_tests.py
amitmiran137
pushed a commit
to ofekisr/incubator-superset
that referenced
this pull request
Sep 27, 2020
…boards_permissions * upstream/master: (46 commits) fix: surface connection error messages on the client (apache#11077) fix(jest): using UTC mock date (apache#11079) removing unused component (apache#11072) changing to the correct hex color (apache#11073) style: remove unecessary padding (apache#11071) fix: database list checkboxes (apache#11068) feat: adding all icons from the design system to the codebase (apache#11033) fix: sql lab autocomplete width (apache#11063) clickable labels have outlines, storybook shows them (apache#11034) fixed routes for customer in docs (apache#11052) Revert "style: fix checkbox color (apache#10970)" (apache#11051) feat: add "created by" to dashboard CRUD view (apache#11030) Changed `tags.py` and `helpers.py` in `models` module: removed disabled pylint rule `unused_import`, changed unused arguments to private and removed disabled rule `unused-argument. Removed redundant rules.` (apache#11037) chore: updated lint rules in models module (apache#11036) Removed disable global pytlint rule `standarderror-builtin` which isn't appearing for Python3 (apache#11038) Enabled argument-differ for bulk_delete (apache#11039) Enabled no-self-use pylint rule in security. Formatter (apache#11041) Changed variable name from capitals to lowercase and changed lint rule (apache#11044) Revert "ESLint: Re-enable rule default-props-match-prop-types (apache#10868)" (apache#11050) feat(saved_queries): add custom api filter for all string & text fields (apache#11031) ... # Conflicts: # superset/config.py # tests/dashboards/api_tests.py
rorymillersoft
referenced
this pull request
in nets-aric/incubator-superset
Oct 28, 2020
…_additions * commit 'c14a06db4185b9b043116708b649b0be2ad17a1f': Revert "style: fix checkbox color (#10970)" feat: add "created by" to dashboard CRUD view (#11030) Changed `tags.py` and `helpers.py` in `models` module: removed disabled pylint rule `unused_import`, changed unused arguments to private and removed disabled rule `unused-argument. Removed redundant rules.` (#11037) chore: updated lint rules in models module (#11036) Removed disable global pytlint rule `standarderror-builtin` which isn't appearing for Python3 (#11038) Enabled argument-differ for bulk_delete (#11039) Enabled no-self-use pylint rule in security. Formatter (#11041) Changed variable name from capitals to lowercase and changed lint rule (#11044) Revert "ESLint: Re-enable rule default-props-match-prop-types (#10868)" (#11050) feat(saved_queries): add custom api filter for all string & text fields (#11031) Support jinja templates (#11008)
auxten
pushed a commit
to auxten/incubator-superset
that referenced
this pull request
Nov 20, 2020
* style: fix checkbox color * lint * wrap test into theme
auxten
pushed a commit
to auxten/incubator-superset
that referenced
this pull request
Nov 20, 2020
This reverts commit e4e78b6.
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
This reverts commit 7ac02cf.
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.