Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: double scroll bars on dataset editor #11095

Merged
merged 2 commits into from
Sep 29, 2020

Conversation

lilykuang
Copy link
Member

SUMMARY

  • fix double scroll bars on dataset editor
  • add table_name field for virtual tab

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

https://www.loom.com/share/d701c13497724c3fa2c547718e583e82

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@mistercrunch mistercrunch merged commit 8b458ac into apache:master Sep 29, 2020
@nytai nytai deleted the lily/fix-double-scroll-bar branch September 29, 2020 19:15
auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
* fix double scroll bar on dataset editor

* add table name to virtual tab
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.38.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 0.38.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants