Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Alembic migration 18532d70ab98 #11136

Merged
merged 1 commit into from Oct 2, 2020
Merged

Conversation

john-bodley
Copy link
Member

@john-bodley john-bodley commented Oct 1, 2020

SUMMARY

This PR reverts some of the logic from this commit as it seems that this constraint may not exist for all MySQL deployments resulting in the migration to fail.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

Ran

superset db upgrade
superset db downgrade

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@codecov-commenter
Copy link

codecov-commenter commented Oct 1, 2020

Codecov Report

Merging #11136 into master will decrease coverage by 4.18%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11136      +/-   ##
==========================================
- Coverage   65.84%   61.66%   -4.19%     
==========================================
  Files         826      826              
  Lines       39016    39016              
  Branches     3667     3667              
==========================================
- Hits        25689    24058    -1631     
- Misses      13217    14777    +1560     
- Partials      110      181      +71     
Flag Coverage Δ
#cypress ?
#javascript 62.21% <ø> (ø)
#python 61.33% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...532d70ab98_fix_table_unique_constraint_in_mysql.py 0.00% <0.00%> (ø)
superset-frontend/src/SqlLab/App.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/explore/App.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/dashboard/App.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/explore/index.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/dashboard/index.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/setup/setupColors.js 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/chart/ChartContainer.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/setup/setupFormatters.js 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/explore/reducers/index.js 0.00% <0.00%> (-100.00%) ⬇️
... and 169 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 017e5ac...69391b8. Read the comment docs.

Copy link
Member

@dpgaspar dpgaspar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @john-bodley

@dpgaspar dpgaspar merged commit e90c63f into master Oct 2, 2020
auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
@amitmiran137 amitmiran137 deleted the john-bodley--fix-18532d70ab98 branch March 29, 2021 18:10
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.38.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 0.38.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants