Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bring back type ignore for config import #11333

Merged
merged 1 commit into from Oct 19, 2020

Conversation

kkucharc
Copy link
Contributor

@kkucharc kkucharc commented Oct 19, 2020

Quickfix
Without #type ignore there is CI problem in pre-commit:

superset/config.py:959: error: Incompatible import of "CELERY_CONFIG" (imported name has type "Type[superset_config.CeleryConfig]", local name has type "Type[superset.config.CeleryConfig]")
superset/config.py:959: error: Incompatible import of "CeleryConfig" (imported name has type "Type[superset_config.CeleryConfig]", local name has type "Type[superset.config.CeleryConfig]")

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@codecov-io
Copy link

codecov-io commented Oct 19, 2020

Codecov Report

Merging #11333 into master will increase coverage by 0.04%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11333      +/-   ##
==========================================
+ Coverage   65.66%   65.71%   +0.04%     
==========================================
  Files         835      835              
  Lines       39656    39656              
  Branches     3604     3604              
==========================================
+ Hits        26042    26061      +19     
+ Misses      13505    13486      -19     
  Partials      109      109              
Flag Coverage Δ
#cypress 56.03% <ø> (+0.26%) ⬆️
#javascript 62.67% <ø> (ø)
#python 60.89% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/config.py 90.15% <0.00%> (ø)
superset/db_engine_specs/sqlite.py 65.62% <0.00%> (-9.38%) ⬇️
superset/utils/celery.py 82.14% <0.00%> (-3.58%) ⬇️
superset/result_set.py 96.69% <0.00%> (-1.66%) ⬇️
superset/db_engine_specs/presto.py 82.07% <0.00%> (+0.64%) ⬆️
...perset-frontend/src/views/CRUD/chart/ChartList.tsx 83.33% <0.00%> (+0.79%) ⬆️
...t-frontend/src/dashboard/actions/dashboardState.js 51.63% <0.00%> (+1.30%) ⬆️
.../src/dashboard/components/gridComponents/Chart.jsx 85.71% <0.00%> (+2.04%) ⬆️
...rontend/src/visualizations/FilterBox/FilterBox.jsx 70.37% <0.00%> (+9.87%) ⬆️
...ontend/src/dashboard/components/dnd/handleHover.js 100.00% <0.00%> (+12.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 735123d...3cfd33c. Read the comment docs.

@kkucharc kkucharc requested review from rusackas, mistercrunch and willbarrett and removed request for rusackas, willbarrett and mistercrunch October 19, 2020 18:32
@kkucharc
Copy link
Contributor Author

cc: @willbarrett @mistercrunch

@villebro
Copy link
Member

Going to merge this to get green checkmarks back on PRs (we need to sort out these linting mismatches on mypy/black)

@villebro villebro merged commit 55c2892 into apache:master Oct 19, 2020
@mistercrunch
Copy link
Member

Thanks for fixing this. I've had some issues with tox/mypy/pyenv lately where I think mypy/tox were using the wrong version of python in some cases. This helped https://pypi.org/project/tox-pyenv/, unclear on mypy / pre-commit

auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.0.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants