Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixing broken Cypress test #11453

Merged
merged 3 commits into from Oct 28, 2020
Merged

Conversation

rusackas
Copy link
Member

@rusackas rusackas commented Oct 28, 2020

SUMMARY

A test ("should edit correctly" within card_view.test.ts) is failing on various PRs. It looks like there's a data-test attribute that doesn't match between Cypress code and the React code.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

n/a

TEST PLAN

If CI passes, we're good.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@rusackas rusackas changed the title fix: Cypress test had a bad data-test selector fix: Fixing broken Cypress test Oct 28, 2020
@codecov-io
Copy link

codecov-io commented Oct 28, 2020

Codecov Report

Merging #11453 into master will increase coverage by 4.36%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11453      +/-   ##
==========================================
+ Coverage   62.23%   66.59%   +4.36%     
==========================================
  Files         863      863              
  Lines       40983    40986       +3     
  Branches     3694     3694              
==========================================
+ Hits        25506    27296    +1790     
+ Misses      15298    13593    -1705     
+ Partials      179       97      -82     
Flag Coverage Δ
#cypress 57.00% <ø> (?)
#javascript 62.88% <ø> (ø)
#python 61.90% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...et-frontend/src/SqlLab/components/LimitControl.tsx 89.36% <0.00%> (-1.95%) ⬇️
superset/db_engine_specs/presto.py 81.64% <0.00%> (-0.65%) ⬇️
.../src/components/dataViewCommon/TableCollection.tsx 100.00% <0.00%> (ø)
...-frontend/src/datasource/ChangeDatasourceModal.tsx 74.19% <0.00%> (+0.42%) ⬆️
superset/views/core.py 74.35% <0.00%> (+0.48%) ⬆️
superset/models/core.py 89.13% <0.00%> (+0.83%) ⬆️
...rontend/src/SqlLab/components/AceEditorWrapper.tsx 60.75% <0.00%> (+1.26%) ⬆️
...ashboard/components/gridComponents/ChartHolder.jsx 79.16% <0.00%> (+1.38%) ⬆️
...perset-frontend/src/components/CopyToClipboard.jsx 36.36% <0.00%> (+1.51%) ⬆️
superset-frontend/src/utils/common.js 74.19% <0.00%> (+1.61%) ⬆️
... and 176 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 155b5ed...f513ee9. Read the comment docs.

@rusackas rusackas merged commit 6841167 into apache:master Oct 28, 2020
@rusackas rusackas deleted the fixing-cypress-test branch October 28, 2020 05:51
auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
* fixing bad data-test selector

* linting

* typo... because I got all excited.
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.0.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants