New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fixing broken Cypress test #11453
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rusackas
changed the title
fix: Cypress test had a bad data-test selector
fix: Fixing broken Cypress test
Oct 28, 2020
ktmud
reviewed
Oct 28, 2020
superset-frontend/cypress-base/cypress/integration/chart_list/card_view.test.ts
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #11453 +/- ##
==========================================
+ Coverage 62.23% 66.59% +4.36%
==========================================
Files 863 863
Lines 40983 40986 +3
Branches 3694 3694
==========================================
+ Hits 25506 27296 +1790
+ Misses 15298 13593 -1705
+ Partials 179 97 -82
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
mistercrunch
approved these changes
Oct 28, 2020
This was referenced Oct 28, 2020
auxten
pushed a commit
to auxten/incubator-superset
that referenced
this pull request
Nov 20, 2020
* fixing bad data-test selector * linting * typo... because I got all excited.
mistercrunch
added
🏷️ bot
A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels
🚢 1.0.0
labels
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
A test ("should edit correctly" within
card_view.test.ts
) is failing on various PRs. It looks like there's a data-test attribute that doesn't match between Cypress code and the React code.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
n/a
TEST PLAN
If CI passes, we're good.
ADDITIONAL INFORMATION