Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix (explore): handle null value in date filter #11655

Merged

Conversation

graceguo-supercat
Copy link

@graceguo-supercat graceguo-supercat commented Nov 11, 2020

SUMMARY

when Date Filter got null in props, explore view page crash and throw JS error like:

TypeError: Cannot read property 'indexOf' of null

TEST PLAN

CI and manual test

@graceguo-supercat graceguo-supercat changed the title [fix] handle null value in date filter fix: [explore view] handle null value in date filter Nov 11, 2020
@ktmud
Copy link
Member

ktmud commented Nov 11, 2020

I think the convention is to style the PR title like fix(explore): handle null value in date filter

@codecov-io
Copy link

codecov-io commented Nov 11, 2020

Codecov Report

Merging #11655 (f06661d) into master (329e728) will decrease coverage by 6.83%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11655      +/-   ##
==========================================
- Coverage   62.26%   55.43%   -6.84%     
==========================================
  Files         873      406     -467     
  Lines       42306    14344   -27962     
  Branches     3971     3691     -280     
==========================================
- Hits        26341     7951   -18390     
+ Misses      15785     6230    -9555     
+ Partials      180      163      -17     
Flag Coverage Δ
cypress 55.43% <50.00%> (?)
javascript ?
python ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../explore/components/controls/DateFilterControl.jsx 61.49% <50.00%> (+6.00%) ⬆️
...uperset-frontend/src/dashboard/util/dnd-reorder.js 0.00% <0.00%> (-100.00%) ⬇️
...rset-frontend/src/dashboard/util/getEmptyLayout.js 0.00% <0.00%> (-100.00%) ⬇️
...dashboard/components/resizable/ResizableHandle.jsx 0.00% <0.00%> (-100.00%) ⬇️
.../src/dashboard/util/getFilterScopeFromNodesTree.js 0.00% <0.00%> (-93.48%) ⬇️
...src/dashboard/components/gridComponents/Header.jsx 10.52% <0.00%> (-86.85%) ⬇️
...rc/dashboard/components/gridComponents/Divider.jsx 13.33% <0.00%> (-86.67%) ⬇️
...set-frontend/src/views/CRUD/welcome/EmptyState.tsx 5.71% <0.00%> (-82.10%) ⬇️
...et-frontend/src/components/ListView/ActionsBar.tsx 11.11% <0.00%> (-81.20%) ⬇️
...et-frontend/src/components/Menu/LanguagePicker.tsx 0.00% <0.00%> (-80.00%) ⬇️
... and 775 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 329e728...f06661d. Read the comment docs.

@graceguo-supercat graceguo-supercat changed the title fix: [explore view] handle null value in date filter fix(explore): handle null value in date filter Nov 11, 2020
@graceguo-supercat graceguo-supercat changed the title fix(explore): handle null value in date filter fix (explore): handle null value in date filter Nov 11, 2020
@graceguo-supercat graceguo-supercat merged commit a9f9c4b into apache:master Nov 11, 2020
john-bodley pushed a commit to airbnb/superset-fork that referenced this pull request Nov 11, 2020
auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.0.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 1.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants