fix(chart-data): ignore orderby on sample result type

[villebro]

SUMMARY

If a query object has defined an orderby based on a metric, requesting sample data for the dataset causes an error.

BEFORE

AFTER

TEST PLAN

Local testing + updated test fixture

[codecov-io]

Codecov Report

Merging #11656 (a94a2b7) into master (329e728) will decrease coverage by 6.82%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #11656      +/-   ##
==========================================
- Coverage   62.26%   55.43%   -6.83%     
==========================================
  Files         873      406     -467     
  Lines       42306    14343   -27963     
  Branches     3971     3690     -281     
==========================================
- Hits        26341     7951   -18390     
+ Misses      15785     6229    -9556     
+ Partials      180      163      -17     

Flag	Coverage Δ
cypress	55.43% <ø> (?)
javascript	?
python	?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...uperset-frontend/src/dashboard/util/dnd-reorder.js	0.00% <0.00%> (-100.00%)	⬇️
...rset-frontend/src/dashboard/util/getEmptyLayout.js	0.00% <0.00%> (-100.00%)	⬇️
...dashboard/components/resizable/ResizableHandle.jsx	0.00% <0.00%> (-100.00%)	⬇️
.../src/dashboard/util/getFilterScopeFromNodesTree.js	0.00% <0.00%> (-93.48%)	⬇️
...src/dashboard/components/gridComponents/Header.jsx	10.52% <0.00%> (-86.85%)	⬇️
...rc/dashboard/components/gridComponents/Divider.jsx	13.33% <0.00%> (-86.67%)	⬇️
...set-frontend/src/views/CRUD/welcome/EmptyState.tsx	5.71% <0.00%> (-82.10%)	⬇️
...et-frontend/src/components/ListView/ActionsBar.tsx	11.11% <0.00%> (-81.20%)	⬇️
...et-frontend/src/components/Menu/LanguagePicker.tsx	0.00% <0.00%> (-80.00%)	⬇️
superset-frontend/src/components/Link.tsx	7.69% <0.00%> (-79.81%)	⬇️
... and 773 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 329e728...a94a2b7. Read the comment docs.

[dpgaspar]

Would be nice to add a simple test to assert this

[villebro]

@dpgaspar there's actually a test that would have failed before with the updated fixture (there's a specific test case for the sample result type): https://github.com/apache/incubator-superset/blob/master/tests/query_context_tests.py#L235-L251