chore: Add home link to navbar

[agatapst]

SUMMARY

This PR adds new element to the top navbar - HOME link redirecting to the homepage.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Navbar before:

Navbar after:

TEST PLAN

First, run command superset init to create default roles and permissions (navbar varies for different types of users, but home link should be seen by every user.) Then verify manually by visiting some application page.

ADDITIONAL INFORMATION

• Has associated issue:
• Changes UI
• Requires DB Migration.
• Confirm DB Migration upgrade and downgrade tested.
• Introduces new feature or API
• Removes existing feature or API

cc @junlincc @rusackas

[codecov-io]

Codecov Report

Merging #11851 (258e5b8) into master (9dd33d5) will decrease coverage by 2.99%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master   #11851      +/-   ##
==========================================
- Coverage   66.71%   63.71%   -3.00%     
==========================================
  Files         917      917              
  Lines       44700    44735      +35     
  Branches     4235     4236       +1     
==========================================
- Hits        29820    28502    -1318     
- Misses      14762    16056    +1294     
- Partials      118      177      +59     

Flag	Coverage Δ
cypress	?
javascript	62.94% <ø> (-0.02%)	⬇️
python	64.15% <50.00%> (+0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
superset-frontend/src/components/Menu/Menu.tsx	63.51% <ø> (-31.09%)	⬇️
superset/app.py	81.20% <50.00%> (-0.24%)	⬇️
superset-frontend/src/SqlLab/App.jsx	0.00% <0.00%> (-100.00%)	⬇️
superset-frontend/src/explore/App.jsx	0.00% <0.00%> (-100.00%)	⬇️
superset-frontend/src/dashboard/App.jsx	0.00% <0.00%> (-100.00%)	⬇️
superset-frontend/src/explore/index.jsx	0.00% <0.00%> (-100.00%)	⬇️
superset-frontend/src/dashboard/index.jsx	0.00% <0.00%> (-100.00%)	⬇️
superset-frontend/src/setup/setupColors.js	0.00% <0.00%> (-100.00%)	⬇️
superset-frontend/src/chart/ChartContainer.jsx	0.00% <0.00%> (-100.00%)	⬇️
superset-frontend/src/explore/reducers/index.js	0.00% <0.00%> (-100.00%)	⬇️
... and 141 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9dd33d5...258e5b8. Read the comment docs.

[junlincc]

@eugeniamz

[etr2460]

I'm curious, isn't this redundant when you consider the Superset logo also goes to the welcome page? @junlincc what was the design/product rationale around this change?

[willbarrett]

@etr2460 it's possible to override the URL and logo in Superset, so this provides an additional way to get to the Superset home page when that configuration is leveraged.

[nytai]

@etr2460 this is in case someone has the LOGO_TARGET_PATH flag set, there's no other way to navigate to the home screen.

[junlincc]

@etr2460
currently, companies that forked Superset, don't have any direct entry points to go back to the landing page/home page within the product. since the logo usually takes users to the workspaces or their own company home page.

[etr2460]

Thanks for the clarification! Maybe we only show the new menu option if the LOGO_TARGET_PATH is set then?

[agatapst]

@junlincc thanks for your reply
@etr2460 that's good idea, thanks for the tip!

To test option with logo target path set, LOGO_TARGET_PATH can be found in config.py file. It can be changed to i.e. LOGO_TARGET_PATH = 'https://superset.apache.org/'. Then Home link will be shown.

[etr2460]

lgtm, thanks for addressing my comment!