refactor : Transform FilterScopeModal to Typescript #11964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #11964 +/- ##
==========================================
- Coverage 63.75% 63.65% -0.11%
==========================================
Files 941 941
Lines 45654 45709 +55
Branches 4389 4396 +7
==========================================
- Hits 29106 29094 -12
- Misses 16371 16436 +65
- Partials 177 179 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
rusackas
reviewed
Dec 9, 2020
| super(props); | ||
|
|
||
| this.modal = React.createRef(); | ||
| this.handleCloseModal = this.handleCloseModal.bind(this); | ||
| } | ||
|
|
||
| handleCloseModal() { | ||
| handleCloseModal(): any { |
There was a problem hiding this comment.
Suggested change
| handleCloseModal(): any { | |
| handleCloseModal(): void { |
rusackas
reviewed
Dec 9, 2020
rusackas
approved these changes
Dec 9, 2020
|
|
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Transform FilterScopeModal to Typescript