Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add new default dashboard #12044

Merged
merged 3 commits into from Dec 15, 2020
Merged

Conversation

betodealmeida
Copy link
Member

SUMMARY

This PR adds a new dashboard showing sales of vehicles. It uses the new import/export framework for examples (see #12026), and required adding more types for the data import, as well as quarterly time grain to the Sqlite engine spec.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screenshot_2020-12-14 Sales Dashboard

Screenshot_2020-12-14 Sales Dashboard(1)

TEST PLAN

Installed Superset from scratch, dashboard is imported correctly (see screenshots) together with all assets (charts, dataset and data).

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@amitmiran137
Copy link
Member

I must say this looks super elegent

@betodealmeida
Copy link
Member Author

I must say this looks super elegent

Props to @srinify for that! :)

@codecov-io
Copy link

codecov-io commented Dec 15, 2020

Codecov Report

Merging #12044 (63b71c8) into master (5e811a1) will decrease coverage by 6.72%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12044      +/-   ##
==========================================
- Coverage   66.95%   60.23%   -6.73%     
==========================================
  Files         957      912      -45     
  Lines       47003    44981    -2022     
  Branches     4589     4059     -530     
==========================================
- Hits        31471    27093    -4378     
- Misses      15404    17888    +2484     
+ Partials      128        0     -128     
Flag Coverage Δ
cypress 53.13% <ø> (+4.48%) ⬆️
javascript ?
python 64.04% <50.00%> (-0.31%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/db_engine_specs/sqlite.py 65.62% <ø> (-9.38%) ⬇️
superset/datasets/commands/importers/v1/utils.py 58.62% <50.00%> (+2.68%) ⬆️
...uperset-frontend/src/dashboard/util/dnd-reorder.js 0.00% <0.00%> (-100.00%) ⬇️
...rset-frontend/src/dashboard/util/getEmptyLayout.js 0.00% <0.00%> (-100.00%) ⬇️
...dashboard/components/resizable/ResizableHandle.jsx 0.00% <0.00%> (-100.00%) ⬇️
.../src/dashboard/util/getFilterScopeFromNodesTree.js 0.00% <0.00%> (-93.48%) ⬇️
...set-frontend/src/views/CRUD/alert/ExecutionLog.tsx 11.76% <0.00%> (-88.24%) ⬇️
...src/dashboard/components/gridComponents/Header.jsx 10.52% <0.00%> (-86.85%) ⬇️
...rc/dashboard/components/gridComponents/Divider.jsx 13.33% <0.00%> (-86.67%) ⬇️
...ontend/src/dashboard/util/getDashboardFilterKey.ts 14.28% <0.00%> (-85.72%) ⬇️
... and 363 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e811a1...63b71c8. Read the comment docs.

Copy link
Member

@hughhhh hughhhh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dope!!!!!

@betodealmeida betodealmeida changed the base branch from ch3883 to master December 15, 2020 21:49
@betodealmeida betodealmeida merged commit 77cae64 into apache:master Dec 15, 2020
ktmud added a commit to ktmud/superset that referenced this pull request Dec 15, 2020
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.0.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XXL 🚢 1.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants