fix: Python dependencies in #11499 #12079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
john-bodley
commented
Dec 16, 2020
| @@ -17,4 +17,4 @@ | |||
| # under the License. | |||
| -e file:. | |||
| pyrsistent>=0.16.1,<0.17 | |||
| importlib-metadata>=1.7.0, <2 | |||
There was a problem hiding this comment.
Needed to resolve conflicting versions.
| pydruid>=0.6.1,<0.7 | ||
| pyhive[hive]>=0.6.1 | ||
| tableschema |
|
|
| @@ -35,9 +35,9 @@ pyhive[hive,presto]==0.6.3 # via -r requirements/development.in, -r requirement | |||
| pylint==2.6.0 # via -r requirements/testing.in | |||
| pytest-cov==2.10.1 # via -r requirements/testing.in | |||
| pytest==6.1.2 # via -r requirements/testing.in, pytest-cov | |||
| redis==3.5.3 # via -r requirements/testing.in | |||
There was a problem hiding this comment.
Redis is currently required for running tests.
There was a problem hiding this comment.
@robdiciuccio this will be inherited from base.in.
| @@ -10,7 +10,6 @@ | |||
| gevent==20.9.0 # via -r requirements/docker.in | |||
| greenlet==0.4.17 # via gevent | |||
| psycopg2-binary==2.8.6 # via -r requirements/docker.in | |||
| redis==3.5.3 # via -r requirements/docker.in | |||
There was a problem hiding this comment.
This is replaced by the requirement in base, yes?
robdiciuccio
approved these changes
Dec 16, 2020
Codecov Report
@@ Coverage Diff @@
## master #12079 +/- ##
==========================================
- Coverage 65.96% 63.44% -2.52%
==========================================
Files 959 959
Lines 47160 47160
Branches 4613 4613
==========================================
- Hits 31111 29923 -1188
- Misses 15898 17053 +1155
- Partials 151 184 +33
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
john-bodley
added a commit
to airbnb/superset-fork
that referenced
this pull request
Dec 16, 2020
Co-authored-by: John Bodley <john.bodley@airbnb.com> (cherry picked from commit c306368)
amitmiran137
pushed a commit
to simcha90/incubator-superset
that referenced
this pull request
Dec 18, 2020
* upstream/master: (55 commits) feat(explore): time picker enhancement (apache#11418) feat: update alert/report icons and column order (apache#12081) feat(explore): metrics and filters controls redesign (apache#12095) feat(alerts/reports): add refresh action (apache#12071) chore: add latest tag action (apache#11148) fix(reports): increase crontab size and alert fixes (apache#12056) Small typo fix in Athena connection docs (apache#12099) feat(queries): security perm simplification (apache#12072) feat(databases): security perm simplification (apache#12036) feat(dashboards): security permissions simplification (apache#12012) feat(logs): security permissions simplification (apache#12061) chore: Remove unused CodeModal (apache#11972) Fix typescript error (apache#12074) fix: handle context-dependent feature flags in CLI (apache#12088) fix: Fix "View in SQLLab" bug (apache#12086) feat(alert/report): add 'not null' condition option to modal (apache#12077) bumping superset ui to 15.18 and deckgl to 0.3.2 (apache#12078) fix: Python dependencies in apache#11499 (apache#12079) reset active tab on open (apache#12048) fix: improve import flow UI/UX (apache#12070) ...
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR fixes #11499 which requires Redis to be a core Python dependency for the
AsyncQueryManagerFlask extension.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
CI. Note the dependencies were updated via
pip-compile-multi --no-upgrade.ADDITIONAL INFORMATION