feat: Custom color schemes support #12210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docs: add FAQ to custom color schemes
ktmud
approved these changes
Dec 30, 2020
Codecov Report
@@ Coverage Diff @@
## master #12210 +/- ##
==========================================
- Coverage 66.20% 59.05% -7.15%
==========================================
Files 996 951 -45
Lines 49174 46661 -2513
Branches 4993 4316 -677
==========================================
- Hits 32554 27556 -4998
- Misses 16476 19105 +2629
+ Partials 144 0 -144
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
mistercrunch
reviewed
Jan 4, 2021
villebro
reviewed
Jan 5, 2021
| @@ -20,6 +20,7 @@ import { setConfig as setHotLoaderConfig } from 'react-hot-loader'; | |||
| import 'abortcontroller-polyfill/dist/abortcontroller-polyfill-only'; | |||
| import moment from 'moment'; | |||
| import { configure } from '@superset-ui/core'; | |||
| import ColorScheme from '@superset-ui/core/lib/color/ColorScheme'; | |||
There was a problem hiding this comment.
We should probably export this (and other related ones) in @superset-ui/core.
villebro
reviewed
Jan 6, 2021
villebro
approved these changes
Jan 7, 2021
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Today colors schemes are loaded from @superset-ui/core
we should have support for individual deployments to inject their own sets of color scheme
the mechanism was copied from setup plugins logic
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
ADDITIONAL INFORMATION