chore: update instructions for Pinot in connecting to databases #12238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pinot connection fix
etr2460
reviewed
Jan 4, 2021
| @@ -29,7 +29,7 @@ A list of some of the recommended packages. | |||
| |[Apache Hive](/docs/databases/hive)|```pip install pyhive```|```hive://hive@{hostname}:{port}/{database}```| | |||
| |[Apache Impala](/docs/databases/impala)|```pip install impala```|```impala://{hostname}:{port}/{database}```| | |||
| |[Apache Kylin](/docs/databases/kylin)|```pip install kylinpy```|```kylin://<username>:<password>@<hostname>:<port>/<project>?<param1>=<value1>&<param2>=<value2>```| | |||
| |[Apache Pinot](/docs/databases/pinot)|```pip install pinotdb```|```pinot+http://CONTROLLER:5436/ query?server=http://CONTROLLER:5983/```| | |||
| |[Apache Pinot](/docs/databases/pinot)|```pip install pinotdb```|```pinot+http://BROKER:5436/query?server=http://CONTROLLER:5983/```| | |||
There was a problem hiding this comment.
reading the Pinot docs, it looks like maybe this should be pinot:// instead of pinot+http://, do you think that change should be made here too?
There was a problem hiding this comment.
I strongly second this, we should drop the +http
There was a problem hiding this comment.
yes drop the +http
junlincc
added
new:contributor
|
hey @pablo-tech if you can rebase this branch and address the comment, we can merge this! |
|
@srinify it's rebased, please merge |
|
hey @pablo-tech it looks like the PR Lint check is failing: https://github.com/apache/superset/pull/12238/checks?check_run_id=1921219267 I've edited the title of the PR this time for you :) For future reference, try to match the format like the error suggests: "chore: update pinot index.mdx" etc |
srinify
changed the title
srinify
approved these changes
Feb 23, 2021
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Superset -> Pinot connection fix
SUMMARY
The pinot Pinot connection instructions mention the CONTROLLER twice, but in one of those it should be the BROKER instead
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
Per the Apache Pinot instructions on integration with Superset here https://docs.pinot.apache.org/integrations/superset
ADDITIONAL INFORMATION
Only impacts the Superset database drivers instructions page https://superset.apache.org/docs/databases/installing-database-drivers